From owner-svn-src-all@FreeBSD.ORG Tue Jun 5 13:13:07 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 89DB6106566B; Tue, 5 Jun 2012 13:13:07 +0000 (UTC) (envelope-from ache@vniz.net) Received: from vniz.net (vniz.net [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 0177E8FC0C; Tue, 5 Jun 2012 13:13:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vniz.net (8.14.5/8.14.5) with ESMTP id q55DD5wP014120; Tue, 5 Jun 2012 17:13:05 +0400 (MSK) (envelope-from ache@vniz.net) Received: (from ache@localhost) by localhost (8.14.5/8.14.5/Submit) id q55DD5ut014119; Tue, 5 Jun 2012 17:13:05 +0400 (MSK) (envelope-from ache) Date: Tue, 5 Jun 2012 17:13:05 +0400 From: Andrey Chernov To: Joerg Sonnenberger Message-ID: <20120605131305.GF13306@vniz.net> Mail-Followup-To: Andrey Chernov , Joerg Sonnenberger , svn-src-all@FreeBSD.ORG, Dimitry Andric , src-committers@FreeBSD.ORG, svn-src-head@FreeBSD.ORG References: <201206042134.q54LYoVJ067685@svn.freebsd.org> <4FCDBE69.6080906@FreeBSD.org> <20120605123901.GA13306@vniz.net> <20120605125520.GA12045@britannica.bec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120605125520.GA12045@britannica.bec.de> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Dimitry Andric Subject: Re: svn commit: r236582 - head/lib/libc/stdlib X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2012 13:13:07 -0000 On Tue, Jun 05, 2012 at 02:55:20PM +0200, Joerg Sonnenberger wrote: > On Tue, Jun 05, 2012 at 04:39:01PM +0400, Andrey Chernov wrote: > > Moreover, standard metion "unsuccessful call" case for free() where errno > > state is totally undefined. > > ...which would be a programming mistake in first place and is valid as > justification. Not only that (I mean programming mistake in the realpath). F.e. internal free/malloc state can be damaged by other code even earlier. But all of this is not the case, since POSIX allows it to modify errno on _success_, which is main reason of the change. Please see http://austingroupbugs.net/view.php?id=385 -- http://ache.vniz.net/