From owner-cvs-all  Mon Oct  1 13: 1:12 2001
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 12F4437B401; Mon,  1 Oct 2001 13:01:08 -0700 (PDT)
Received: (from rwatson@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f91K18B18115;
	Mon, 1 Oct 2001 13:01:08 -0700 (PDT)
	(envelope-from rwatson)
Message-Id: <200110012001.f91K18B18115@freefall.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Mon, 1 Oct 2001 13:01:08 -0700 (PDT)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/sys/kern vfs_syscalls.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

rwatson     2001/10/01 13:01:08 PDT

  Modified files:
    sys/kern             vfs_syscalls.c 
  Log:
  o Complete the migration from suser error checking in the following form
    in vfs_syscalls.c:
  
      if (mp->mnt_stat.f_owner != p->p_ucred->cr_uid &&
          (error = suser_td(td)) != 0) {
              unwrap_lots_of_stuff();
              return (error);
      }
  
    to:
  
      if (mp->mnt_stat.f_owner != p->p_ucred->cr_uid) {
              error = suser_td(td);
              if (error) {
                  unwrap_lots_of_stuff();
                  return (error);
              }
      }
  
    This makes the code more readable when complex clauses are in use,
    and minimizes conflicts for large outstanding patchsets modifying the
    kernel authorization code (of which I have several), especially where
    existing authorization and context code are combined in the same if()
    conditional.
  
  Obtained from:	TrustedBSD Project
  
  Revision  Changes    Path
  1.207     +44 -23    src/sys/kern/vfs_syscalls.c


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message