From owner-freebsd-net@FreeBSD.ORG Tue May 27 17:19:06 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 208C3AF7 for ; Tue, 27 May 2014 17:19:06 +0000 (UTC) Received: from mail-ve0-x22c.google.com (mail-ve0-x22c.google.com [IPv6:2607:f8b0:400c:c01::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D0DE8209C for ; Tue, 27 May 2014 17:19:05 +0000 (UTC) Received: by mail-ve0-f172.google.com with SMTP id oz11so11020862veb.31 for ; Tue, 27 May 2014 10:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=1K+5ByemqK7OR2J8idrmSKkSy1zjL1ruyzNJdZNl7Dw=; b=UYs3wNZjZ3dn++8Lo7uJS03aINrmZMMb+J8PZMdbw+wVflj5ZCBxiuvVUtBkY3LSB4 szNrQwqqI55RGNt3viEvQ6pt3Fdi5j1QvSrKajJAgyL5NZS4/WOPPXuMHnKXtl9M7oPD SRzSv3YWh8iiP5V0iJl/NSq3Nlr//frbxuKJf4N50fMuBm1xPNk2yFf6DdJetgO6He6J qtdG2KbJoLZ8s1O6iRo/85SN+Y4Ky3XmJnVEPGh1QA8jHMldA/HYLE3fUyF+81Lh2GWA 9v8qKgo/xwpKqDHaLVMbAatW5NjbwjzzEEzFHrfRsF7ktoKyACVND39y/3u51HwLJ2NU eQ0w== MIME-Version: 1.0 X-Received: by 10.58.74.164 with SMTP id u4mr2202394vev.81.1401211144962; Tue, 27 May 2014 10:19:04 -0700 (PDT) Received: by 10.221.5.74 with HTTP; Tue, 27 May 2014 10:19:04 -0700 (PDT) In-Reply-To: References: <20140526170643.GE40172@onelab2.iet.unipi.it> Date: Tue, 27 May 2014 10:19:04 -0700 Message-ID: Subject: Re: Regarding Netmap in VM From: Jack Vogel To: Luigi Rizzo Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: FreeBSD Net , Prashant Upadhyaya X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 May 2014 17:19:06 -0000 Ya, it might be nice to do a bunch of cleanup like that, maybe once the i40e release happens I'll have some time to look into that. Jack On Tue, May 27, 2014 at 2:49 AM, Luigi Rizzo wrote: > > > > On Tue, May 27, 2014 at 5:00 AM, Jack Vogel wrote: > >> I don't think we've ever tried this at Intel either. I had meant to check >> the ixv code to >> see if it had your code in it Luigi but got distracted, if it doesn't >> then it obviously can't >> work for the case of a VM. >> > > ixv.c does not contain the netmap hooks though it might be > relatively straightforward to add them, possibly reusing > the same netmap hooks and support functions used in ixgbe.c > > As a matter of fact, there seems to be a large amount > of duplicated code between ixv.c and ixgbe.c, > so i wonder whether it makes sense to remove the duplication and > use just a single copy of the common parts ? > > cheers > luigi >