Date: Wed, 30 Jan 2002 13:21:11 +0200 From: Peter Pentchev <roam@ringlet.net> To: net@FreeBSD.org Subject: Re: misc/34390: incorrect error with getaddrinfo with hostname+AI_NUMERICHOST Message-ID: <20020130132111.E4374@straylight.oblivion.bg>
next in thread | raw e-mail | index | archive | help
Hi, Does anybody see any possible problems stemming from the patch in the following reply to PR misc/34390? G'luck, Peter -- This sentence was in the past tense. ----- Forwarded message from Peter Pentchev <roam@ringlet.net> ----- Date: Wed, 30 Jan 2002 13:19:35 +0200 From: Peter Pentchev <roam@ringlet.net> To: Serge van den Boom <svdb@stack.nl> Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: misc/34390: incorrect error with getaddrinfo with hostname+AI_NUMERICHOST On Tue, Jan 29, 2002 at 12:06:36AM +0100, Serge van den Boom wrote: > > >Number: 34390 > >Category: misc > >Synopsis: incorrect error with getaddrinfo with hostname+AI_NUMERICHOST > >Originator: Serge van den Boom > >Release: FreeBSD 4.5-RC i386 > >Description: > When using getaddrinfo with AI_NUMERICHOST set in the options field of > the hints structure, and passing a non-numeric host name, EAI_NODATA is > returned. RFC 2553 requires an error code of EAI_NONAME in that case though, > and this is what the getaddrinfo man page also says (in fact it's the same > text). Can you try the following patch? It seems to fix the problem for me. It is made against RELENG_4 sources, but applies cleanly to -CURRENT, too. G'luck, Peter Index: src/lib/libc/net/getaddrinfo.c =================================================================== RCS file: /home/ncvs/src/lib/libc/net/getaddrinfo.c,v retrieving revision 1.9.2.8 diff -u -r1.9.2.8 getaddrinfo.c --- src/lib/libc/net/getaddrinfo.c 15 Jun 2001 22:08:28 -0000 1.9.2.8 +++ src/lib/libc/net/getaddrinfo.c 30 Jan 2002 10:50:07 -0000 @@ -529,7 +529,7 @@ goto good; if (pai->ai_flags & AI_NUMERICHOST) - ERR(EAI_NODATA); + ERR(EAI_NONAME); if (hostname == NULL) ERR(EAI_NODATA); ----- End forwarded message ----- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020130132111.E4374>