From owner-cvs-src-old@FreeBSD.ORG Fri Jan 9 21:03:02 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A5D54106574B for ; Fri, 9 Jan 2009 21:03:01 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B840A8FC1E for ; Fri, 9 Jan 2009 21:03:01 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n09L31b6020802 for ; Fri, 9 Jan 2009 21:03:01 GMT (envelope-from mav@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n09L31Wn020788 for cvs-src-old@freebsd.org; Fri, 9 Jan 2009 21:03:01 GMT (envelope-from mav@repoman.freebsd.org) Message-Id: <200901092103.n09L31Wn020788@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to mav@repoman.freebsd.org using -f From: Alexander Motin Date: Fri, 9 Jan 2009 21:02:54 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_7 Subject: cvs commit: src/sys/netgraph ng_base.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jan 2009 21:03:03 -0000 mav 2009-01-09 21:02:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netgraph ng_base.c Log: SVN rev 186976 on 2009-01-09 21:02:54Z by mav MFC rev. 182995 We can't implicitly trust the hook on NGQF_FN/NGQF_FN2 processing in ng_apply_item(). There are possible (and I have got one) use-after-free class panics because of it. If hook is specified, require it to be valid at the apply time. The only exceptions are the internal ng_con_part2(), ng_con_part3() and ng_rmhook_part2() functions which are specially made to work with invalid hooks. Revision Changes Path 1.135.2.12 +14 -6 src/sys/netgraph/ng_base.c