From owner-svn-ports-all@freebsd.org Mon Feb 29 10:12:27 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D072AB7BFE; Mon, 29 Feb 2016 10:12:27 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-lf0-x234.google.com (mail-lf0-x234.google.com [IPv6:2a00:1450:4010:c07::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 939D4C38; Mon, 29 Feb 2016 10:12:26 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: by mail-lf0-x234.google.com with SMTP id l83so40709067lfd.3; Mon, 29 Feb 2016 02:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3bekAYsyoGc6LuiS+2eM0y9550XsQI3qQ1BbaF/KbOw=; b=ASCe1FUQ1PMrUxKOHAtSF6iONRn8Wu5syfjGBf+kvbkBkhDbiixPGuhidxBW9Qea5R PFYPS2wt2Byxy1Ow7M+AgqYtMaOSsG3ipoomg7kJ0ptlj7lfIfrICWCwpn8fabnzmEvl YDegV59e84ldULlPa1wOJ6tFNzqm25/3j+zlukm99IXp+OXmrs+/yrpJ+bSgaupUAfI7 GLqg6WGVlEX+qxA0IabnJ3ZY6561TsiW1CSGhYvlTYR5ggHNt6d4vbQIUMUgvIgEuIQU qYgQ95xqertED/nLB15dAwQOEaJSxAa2kgVxwwtWJQ0uXzoXxkTFobz/b/NSqU8TIvYM 8VmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3bekAYsyoGc6LuiS+2eM0y9550XsQI3qQ1BbaF/KbOw=; b=g8qySSg9YPVhtKtQWnTmTU7LPxQ/CYHQ8Mf/CSWTVRtFkrZC2QioVU7qsfOrFBKXZk VAnnWlLDYsvt9oKkhAUrKtWqlGIEQgESla1bDZajIYKrmVwepyyxSXsJkWkWNZCjQqkL ROIqgshTwf3iASgbzlZ6177Swdx6OOcigEl9EpLTEzE3EwcHSlCj/O+eGDXsp3Kzv6L7 NcqdyLcNtWYZ6c4QiVGHiaGiy+z2msB/QKC7cGpzmQ907ObF2OXi8EJuFZZvrSehYoPV XejenpykAZMjed9bs5bHlzCrPX+HzIR3OebIttGAjcFzrOvbEi0vBItuAuZcNI/dQ5Tj /R0Q== X-Gm-Message-State: AD7BkJIVYhwQOa7qNjQG79EUmUBPIf/EveWpJ8jhWHse5Y5Q+7NfkDe3qiBEsZ4yXYsLaQ== X-Received: by 10.25.85.145 with SMTP id j139mr5184128lfb.131.1456740744030; Mon, 29 Feb 2016 02:12:24 -0800 (PST) Received: from localhost ([93.183.239.2]) by smtp.gmail.com with ESMTPSA id o7sm3107865lfb.15.2016.02.29.02.12.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Feb 2016 02:12:23 -0800 (PST) Date: Mon, 29 Feb 2016 12:12:22 +0200 From: Mykola Golub To: Alexey Dokuchaev Cc: Mikolaj Golub , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r409685 - head/net-mgmt/bsnmp-ucd Message-ID: <20160229101221.GA1152@gmail.com> References: <201602272003.u1RK3AfO017541@repo.freebsd.org> <20160229050336.GA45790@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160229050336.GA45790@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Feb 2016 10:12:27 -0000 On Mon, Feb 29, 2016 at 05:03:37AM +0000, Alexey Dokuchaev wrote: > On Sat, Feb 27, 2016 at 08:03:10PM +0000, Mikolaj Golub wrote: > > New Revision: 409685 > > URL: https://svnweb.freebsd.org/changeset/ports/409685 > > > > Log: > > Fix build on recent 11.0-CURRENT > > That's pretty bad commit message since it does not explain anything: neither > what was the cause of the breakage nor why/how "make depend" magically fixes > it. Sorry. The problem was that on the recent CURRENT generation of ucd_oid.h and ucd_tree.h files, which are included by other *.c files, was not executed as the first step, before compiling other files. On older systems ucd_tree.h and systems ucd_tree.h were always generated as the first step, but now if I run 'make -n' I see the commands are still executed but they are not the first. bsdsnmp-ucd Makefile uses system bsd.snmpmod.mk for this magic. It has commands to generate ${MOD}_oid.h, ${MOD}_tree.c, ${MOD}_tree.h files. It adds these files to SRCS, but I don't see what should guarantee these commands are executed first. There is .ORDER: ${MOD}_tree.c ${MOD}_tree.h but AFAIR .ORDER is for parallel builds? That is why I didn't blame system(make) for this (I did not find recent changes in bsd.snmpmod.mk that could explain the issue), I thought it had been rather an accident that it worked previously. After running 'make depend' I get order I need, though I am not sure this is the right solution. > > > @@ -21,4 +21,7 @@ post-install: > > @${MKDIR} ${STAGEDIR}${EXAMPLESDIR} > > ${INSTALL_DATA} ${WRKSRC}/snmpd.config.sample ${STAGEDIR}${EXAMPLESDIR} > > > > +pre-build: > > + ${MAKE} -C ${WRKSRC} depend > > Also, it should probably be spelled as ${MAKE_CMD} here. Thank, I will change, if there is no objection to my solution after I described the issue. > > ./danfe -- Mykola Golub