From owner-freebsd-python@FreeBSD.ORG Wed Apr 11 19:56:34 2012 Return-Path: Delivered-To: freebsd-python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 643EC106566B; Wed, 11 Apr 2012 19:56:34 +0000 (UTC) (envelope-from jhein@symmetricom.com) Received: from duck.timing.com (duck.symmetricom.us [206.168.13.214]) by mx1.freebsd.org (Postfix) with ESMTP id 2FBE58FC19; Wed, 11 Apr 2012 19:56:34 +0000 (UTC) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by duck.timing.com (8.14.5/8.14.4) with ESMTP id q3BJtlYp054807; Wed, 11 Apr 2012 13:55:47 -0600 (MDT) (envelope-from jhein@symmetricom.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.14.5/8.14.5) with ESMTP id q3BJtaEb082906; Wed, 11 Apr 2012 13:55:36 -0600 (MDT) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.14.5/8.14.5/Submit) id q3BJtQI4082905; Wed, 11 Apr 2012 13:55:26 -0600 (MDT) (envelope-from jhein) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20357.57773.876931.940056@gromit.timing.com> Date: Wed, 11 Apr 2012 13:55:25 -0600 From: John Hein To: Mel Flynn In-Reply-To: <4F85DFED.5050505@acsalaska.net> References: <201204111317.q3BDHksK038176@freefall.freebsd.org> <4F858621.603@yandex.ru> <20357.55785.187568.687487@gromit.timing.com> <4F85DFED.5050505@acsalaska.net> X-Mailer: VM 8.2.0b-8.2.x-reddyuday.r1325 under 23.3.1 (i386-portbld-freebsd7.3) Cc: miwi@freebsd.org, mexas@bristol.ac.uk, bug-followup@freebsd.org, Ruslan Mahmatkhanov , freebsd-python@freebsd.org Subject: Re: ports/159215: Mk/bsd.python.mk: PYTHON_VERSION is ignored X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2012 19:56:34 -0000 Mel Flynn wrote at 21:47 +0200 on Apr 11, 2012: > On 4/11/2012 21:22, John Hein wrote: > > > But (#1) neither work because bsd.port.pre.mk defines PYTHON_PORTSDIR > > before the new python version can be set by the ARCH == amd64 test. > > > > But (#2) you can't put the ARCH .if test before bsd.port.pre.mk since > > ARCH is not defined at that point. > > Just a thought: > You can simplify the hack by including bsd.port.options.mk instead of > the first bsd.port.pre.mk. ARCH will be defined while bsd.python.mk > isn't included yet. Indeed. Although it's a bit counterintuitive to include bsd.port.options.mk when there are no OPTIONS. However, it's perhaps safer than including pre.mk twice and hoping no one changes anything above the first that leaves USE_PYTHON defined. Whichever of those hacks is used, there should be a comment about what's going on and why.