From owner-cvs-src@FreeBSD.ORG Thu Apr 15 00:24:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA11516A4D3 for ; Thu, 15 Apr 2004 00:24:30 -0700 (PDT) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 5E65943D49 for ; Thu, 15 Apr 2004 00:24:30 -0700 (PDT) (envelope-from silby@silby.com) Received: (qmail 67892 invoked from network); 15 Apr 2004 07:24:29 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay.pair.com with SMTP; 15 Apr 2004 07:24:29 -0000 X-pair-Authenticated: 209.68.2.70 Date: Thu, 15 Apr 2004 02:32:48 -0500 (CDT) From: Mike Silbersack To: John Baldwin In-Reply-To: <200404132258.31816.jhb@FreeBSD.org> Message-ID: <20040415023200.D10243@odysseus.silby.com> References: <200404120913.i3C9DOkd075451@repoman.freebsd.org> <200404132258.31816.jhb@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Mark Murray cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/random randomdev.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2004 07:24:31 -0000 On Tue, 13 Apr 2004, John Baldwin wrote: > You should drop the lock before uiomove(). If the uio can possibly reference > user memory, then uiomove() will do a copyout() which can fault and thus > sleep if the page is in swap. > > -- > John Baldwin <>< http://www.FreeBSD.org/~jhb/ I'm going to have a similar problem in sendfile when I try to de-giantify it, and I'm sure read / write will have issues as well... will WITNESS catch this potential problem? Mike "Silby" Silbersack