From owner-svn-src-head@freebsd.org Fri Apr 10 17:43:29 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3D6C42C3E58; Fri, 10 Apr 2020 17:43:29 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48zQNJ6Q1nz4Lb6; Fri, 10 Apr 2020 17:43:28 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 03AHhR4G016799; Fri, 10 Apr 2020 10:43:27 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 03AHhR0F016798; Fri, 10 Apr 2020 10:43:27 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202004101743.03AHhR0F016798@gndrsh.dnsmgr.net> Subject: Re: svn commit: r359685 - in head: . etc lib/libc/gen share/mk share/termcap usr.bin/login usr.bin/vgrind usr.sbin/services_mkdb In-Reply-To: <3e0a6d83-e99b-1e09-89e5-c202dbef9433@FreeBSD.org> To: Bryan Drewery Date: Fri, 10 Apr 2020 10:43:27 -0700 (PDT) CC: rgrimes@FreeBSD.org, Maxim Sobolev , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Reply-To: rgrimes@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 48zQNJ6Q1nz4Lb6 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2020 17:43:29 -0000 > On 4/7/2020 3:37 AM, Rodney W. Grimes wrote: > >> Author: sobomax > >> Date: Tue Apr 7 02:46:22 2020 > >> New Revision: 359685 > >> URL: https://svnweb.freebsd.org/changeset/base/359685 > >> > >> Log: > >> Normalize deployment tools usage and definitions by putting into one place > >> instead of sprinkling them out over many disjoint files. This is a follow-up > >> to achieve the same goal in an incomplete rev.348521. > > I have concerns that this factoring out of 5 values that have not changed > > in 25 years is a pessimization, it is one more file that make has to > > open on each invocation. > > > > > > The truth is that this additional file read is on top of hundreds of new > reads per directory in the past few years. It can suck on NFS but > otherwise this 1 change is very minor compared to other additions. One > big example is foo.o.depend for each foo.o. Or bmake doing > realpath(getcwd()) on every invocation. Improving those, or the bmake > job queue, or bmake's overuse of /bin/sh, would go a lot further than > the hit from this commit. True, it was unfair of me to pick on this one change, there are a long slow gradual increase in the disk I/O intensity of buildworld over time. I was more raising that general issue, that we should keep an eye towards that as we make changes to the build system, we should be very careful of anything that pessimizes the build. My concerns are for people, like mdexter, that run Build Option Serveys, which is basically 240 buildwords in a single invocation with run times on the order days to complete, or for CI clusters doing 1000's of builds a week. > -- > Regards, > Bryan Drewery -- Rod Grimes rgrimes@freebsd.org