From owner-freebsd-bugs@freebsd.org  Tue Aug  4 15:44:36 2015
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB48B9B3FB1
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Tue,  4 Aug 2015 15:44:36 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 97C15273
 for <freebsd-bugs@FreeBSD.org>; Tue,  4 Aug 2015 15:44:36 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t74FiabM082859
 for <freebsd-bugs@FreeBSD.org>; Tue, 4 Aug 2015 15:44:36 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 157118] [igb] cleanup error in igb driver -
 igb_setup_receive_structures()
Date: Tue, 04 Aug 2015 15:44:36 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: sbruno@FreeBSD.org
X-Bugzilla-Status: Closed
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc resolution bug_status
Message-ID: <bug-157118-8-IxVIxGEdnF@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-157118-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-157118-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Aug 2015 15:44:36 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=157118

Sean Bruno <sbruno@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbruno@FreeBSD.org
         Resolution|---                         |Works As Intended
             Status|In Progress                 |Closed

--- Comment #1 from Sean Bruno <sbruno@FreeBSD.org> ---
The code appears to not match the description in this ticket anymore.  Closing
it out.

static int
igb_setup_receive_structures(struct adapter *adapter)
{
        struct rx_ring *rxr = adapter->rx_rings;
        int i;

        for (i = 0; i < adapter->num_queues; i++, rxr++)
                if (igb_setup_receive_ring(rxr))
                        goto fail;

        return (0);
fail:
        /*
         * Free RX buffers allocated so far, we will only handle
         * the rings that completed, the failing case will have
         * cleaned up for itself. 'i' is the endpoint.
         */
        for (int j = 0; j < i; ++j) {
                rxr = &adapter->rx_rings[j];
                IGB_RX_LOCK(rxr);
                igb_free_receive_ring(rxr);
                IGB_RX_UNLOCK(rxr);
        }

        return (ENOBUFS);
}

-- 
You are receiving this mail because:
You are the assignee for the bug.