Date: Tue, 04 Aug 2015 15:44:36 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 157118] [igb] cleanup error in igb driver - igb_setup_receive_structures() Message-ID: <bug-157118-8-IxVIxGEdnF@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-157118-8@https.bugs.freebsd.org/bugzilla/> References: <bug-157118-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=157118 Sean Bruno <sbruno@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbruno@FreeBSD.org Resolution|--- |Works As Intended Status|In Progress |Closed --- Comment #1 from Sean Bruno <sbruno@FreeBSD.org> --- The code appears to not match the description in this ticket anymore. Closing it out. static int igb_setup_receive_structures(struct adapter *adapter) { struct rx_ring *rxr = adapter->rx_rings; int i; for (i = 0; i < adapter->num_queues; i++, rxr++) if (igb_setup_receive_ring(rxr)) goto fail; return (0); fail: /* * Free RX buffers allocated so far, we will only handle * the rings that completed, the failing case will have * cleaned up for itself. 'i' is the endpoint. */ for (int j = 0; j < i; ++j) { rxr = &adapter->rx_rings[j]; IGB_RX_LOCK(rxr); igb_free_receive_ring(rxr); IGB_RX_UNLOCK(rxr); } return (ENOBUFS); } -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-157118-8-IxVIxGEdnF>