From owner-cvs-src@FreeBSD.ORG Wed Feb 2 00:25:08 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D80916A4D0; Wed, 2 Feb 2005 00:25:08 +0000 (GMT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id D83FA43D41; Wed, 2 Feb 2005 00:25:07 +0000 (GMT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) j120P7u3012587; Tue, 1 Feb 2005 19:25:07 -0500 (EST) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id j120P7x1012586; Tue, 1 Feb 2005 19:25:07 -0500 (EST) Date: Tue, 1 Feb 2005 19:25:07 -0500 From: Ken Smith To: Ken Smith Message-ID: <20050202002507.GB11980@electra.cse.Buffalo.EDU> References: <200502020021.j120Lcxf088147@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200502020021.j120Lcxf088147@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Feb 2005 00:25:08 -0000 On Wed, Feb 02, 2005 at 12:21:38AM +0000, Ken Smith wrote: > kensmith 2005-02-02 00:21:38 UTC > > FreeBSD src repository > > Modified files: > sys/ufs/ufs ufs_vnops.c > Log: > It was noticed that we do not change a file's access time when it gets > executed. This appears to violate most of the UNIX-ish standards. > One example quote from: > > http://www.opengroup.org/onlinepubs/009695399/functions/exec.html > > Upon successful completion, the exec functions shall mark for update > the st_atime field of the file. If an exec function failed but was > able to locate the process image file, whether the st_atime field is > marked for update is unspecified. Should the exec function succeed, > the process image file shall be considered to have been opened with > open(). > > This appears to take care of it for ufs filesystems, doing the necessary > sanity checks (read-only filesystem, etc) without violating any other > standards (setting atime for any open appears to be allowed in any standards > I could find). > > Noticed by: cperciva > Reviewed by: kan, rwatson > > Revision Changes Path > 1.261 +6 -0 src/sys/ufs/ufs/ufs_vnops.c A similar fix is in the works for ext2fs, I just need to test it a bit more. I don't know if this sort of thing should be MFCed, advice is welcome. It's a user visible change in something that has probably been this way for a long time but the current situation violates standards... -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel |