From owner-cvs-all@FreeBSD.ORG Tue Feb 26 12:16:35 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9871F106567F; Tue, 26 Feb 2008 12:16:35 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 842C213C4D1; Tue, 26 Feb 2008 12:16:35 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m1QCGZIV029992; Tue, 26 Feb 2008 12:16:35 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m1QCGZHD029991; Tue, 26 Feb 2008 12:16:35 GMT (envelope-from kib) Message-Id: <200802261216.m1QCGZHD029991@repoman.freebsd.org> From: Konstantin Belousov Date: Tue, 26 Feb 2008 12:16:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vnode_if.src X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2008 12:16:35 -0000 kib 2008-02-26 12:16:35 UTC FreeBSD src repository Modified files: sys/kern vnode_if.src Log: Do not assert any locks for VOP_PRINT. In particular, do not assert that the vnode interlock is not held. vn_printf() already correctly handles locked and unlocked vnode interlocks, and all the in-tree vop_print methods are interlock-agnostic. Some code calls vprintf() with the vnode interlock held, that causes unjustified panics with INVARIANTS (ffs_syncvnode() as example). Reported by: Peter Holm Revision Changes Path 1.90 +1 -1 src/sys/kern/vnode_if.src