Date: Mon, 12 Mar 2007 19:15:29 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Scott Long <scottl@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <20070312161529.GA1777@rambler-co.ru> In-Reply-To: <200703120925.l2C9Pv1Q050530@repoman.freebsd.org> References: <200703120925.l2C9Pv1Q050530@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Scott, On Mon, Mar 12, 2007 at 09:25:57AM +0000, Scott Long wrote: > scottl 2007-03-12 09:25:57 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/bge if_bge.c=20 > Log: > Add MAC, RX, and TX stats reporting via sysctl. > =20 > Revision Changes Path > 1.185 +147 -10 src/sys/dev/bge/if_bge.c >=20 The following patch eliminates collisions in sysctl names that kernel reports on boot: %%% Index: if_bge.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/dev/bge/if_bge.c,v retrieving revision 1.185 diff -u -p -r1.185 if_bge.c --- if_bge.c 12 Mar 2007 09:25:57 -0000 1.185 +++ if_bge.c 12 Mar 2007 16:14:05 -0000 @@ -4275,9 +4275,9 @@ bge_add_sysctls(struct bge_softc *sc) BGE_SYSCTL_STAT(sc, ctx, "Undersized Packets", children, rxstats.etherStatsUndersizePkts, "UndersizePkts"); BGE_SYSCTL_STAT(sc, ctx, "Inbound Range Length Errors", - children, rxstats.inRangeLengthError, "RangeLengthError"); + children, rxstats.inRangeLengthError, "inRangeLengthError"); BGE_SYSCTL_STAT(sc, ctx, "Outbound Range Length Errors", - children, rxstats.outRangeLengthError, "RangeLengthError"); + children, rxstats.outRangeLengthError, "outRangeLengthError"); =20 tree =3D SYSCTL_ADD_NODE(ctx, schildren, OID_AUTO, "tx", CTLFLAG_RD, NULL, "BGE TX Statistics"); @@ -4308,8 +4308,8 @@ bge_add_sysctls(struct bge_softc *sc) children, txstats.dot3StatsExcessiveCollisions, "ExcessiveCollisions"); BGE_SYSCTL_STAT(sc, ctx, "Late Collisions", - children, txstats.dot3StatsExcessiveCollisions, - "ExcessiveCollisions"); + children, txstats.dot3StatsLateCollisions, + "LateCollisions"); BGE_SYSCTL_STAT(sc, ctx, "Outbound Unicast Packets",=20 children, txstats.ifHCOutUcastPkts, "UcastPkts"); BGE_SYSCTL_STAT(sc, ctx, "Outbound Multicast Packets", %%% Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.2 (FreeBSD) iD8DBQFF9XyhqRfpzJluFF4RAtGBAJ4mxKfOo59B3GGGk6Z/F7zaPTvhkwCfT0UP Ij7b/SPjTSNjf5B4K4U4Cck= =/xBO -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070312161529.GA1777>