Date: Tue, 23 May 2023 09:59:33 -0400 From: Randall Stewart <rrs@netflix.com> To: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> Cc: Randall Ray Stewart <rrs@freebsd.org>, Antoine Brodin <antoine@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 73ee5756dee6 - main - Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. Message-ID: <1E5C3216-1A6F-43AC-AA91-24FA1EA18842@netflix.com> In-Reply-To: <20230522070643.99f8aa0c5509c0d3a5f2ae0b@dec.sakura.ne.jp> References: <20230522070643.99f8aa0c5509c0d3a5f2ae0b@dec.sakura.ne.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_1025A52E-98E4-4DB8-85E6-BD39C353D7B1 Content-Type: multipart/alternative; boundary="Apple-Mail=_2CFBEC81-0A8F-4100-92B3-C15C10F11BC2" --Apple-Mail=_2CFBEC81-0A8F-4100-92B3-C15C10F11BC2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 https://reviews.freebsd.org/D40229 <https://reviews.freebsd.org/D40229>; Should fix this :) R > On May 21, 2023, at 6:06 PM, Tomoaki AOKI <junchoon@dec.sakura.ne.jp> = wrote: >=20 >> On Tue, Apr 4, 2023 at 12:31=E2=80=AFPM Randall Stewart = <rrs@freebsd.org> wrote: >>>=20 >>> The branch main has been updated by rrs: >>>=20 >>> URL: = https://www.google.com/url?q=3Dhttps://cgit.FreeBSD.org/src/commit/?id%3D7= 3ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f&source=3Dgmail-imap&ust=3D16853116= 14000000&usg=3DAOvVaw0HmtU6ylNo8jRrPgvtzIB0 >>>=20 >>> commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f >>> Author: Randall Stewart <rrs@FreeBSD.org> >>> AuthorDate: 2023-04-01 05:46:38 +0000 >>> Commit: Randall Stewart <rrs@FreeBSD.org> >>> CommitDate: 2023-04-01 05:46:38 +0000 >>>=20 >>> Fixes in the tcp infrastructure with respect to stack changes as = well as other infrastructure updates for incoming rack features. >>>=20 >>> So stack switching as always been a bit of a issue. We currently = use a break before make setup which means that >>> if something goes wrong you have to try to get back to a stack. = This patch among a lot of other things changes that so >>> that it is a make before break. We also expand some of the = function blocks in prep for new features in rack that will allow >>> more controlled pacing. We also add other abilities such as the = pathway for a stack to query a previous stack to acquire from >>> it critical state information so things in flight don't get = dropped or mis-handled when switching stacks. We also add the >>> concept of a timer granularity. This allows an alternate stack to = change from the old ticks granularity to microseconds and >>> of course this even gives us a pathway to go to nanosecond = timekeeping if we need to (something for the data center to consider >>> for sure). >>>=20 >>> Once all this lands I will then update rack to begin using all = these new features. >>>=20 >>> Reviewed by: tuexen >>> Sponsored by: Netflix Inc >>> Differential Revision: = https://www.google.com/url?q=3Dhttps://reviews.freebsd.org/D39210&source=3D= gmail-imap&ust=3D1685311614000000&usg=3DAOvVaw1ZouYiMywAnpdYyYCp9T9O >>=20 >> Hi, >>=20 >> Could you hide some stuff in netinet/tcp.h? >> struct http_req breaks curl 8.1.0. >>=20 >> Antoine >=20 > Please refer to Bug 271526 [1], especially Comment 4 [2] by Jonathan > Reynolds. > A patch is proposed there inline (not as an attachment). >=20 > [1] = https://www.google.com/url?q=3Dhttps://bugs.freebsd.org/bugzilla/show_bug.= cgi?id%3D271526&source=3Dgmail-imap&ust=3D1685311614000000&usg=3DAOvVaw2e-= 0D0bz7CAIVj6kvLZOJg >=20 > [2] = https://www.google.com/url?q=3Dhttps://bugs.freebsd.org/bugzilla/show_bug.= cgi?id%3D271526%23c4&source=3Dgmail-imap&ust=3D1685311614000000&usg=3DAOvV= aw154j12MkBXKn2z9_gepR1n >=20 > --=20 > Tomoaki AOKI <junchoon@dec.sakura.ne.jp> ------ Randall Stewart rrs@netflix.com --Apple-Mail=_2CFBEC81-0A8F-4100-92B3-C15C10F11BC2 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><a href=3D"https://reviews.freebsd.org/D40229" = class=3D"">https://reviews.freebsd.org/D40229</a></div><div><br = class=3D""></div><div>Should fix this :)</div><div><br = class=3D""></div><div>R<br class=3D""><blockquote type=3D"cite" = class=3D""><div class=3D"">On May 21, 2023, at 6:06 PM, Tomoaki AOKI = <<a href=3D"mailto:junchoon@dec.sakura.ne.jp" = class=3D"">junchoon@dec.sakura.ne.jp</a>> wrote:</div><br = class=3D"Apple-interchange-newline"><div class=3D""><div = class=3D""><blockquote type=3D"cite" class=3D"">On Tue, Apr 4, 2023 at = 12:31=E2=80=AFPM Randall Stewart <<a href=3D"mailto:rrs@freebsd.org" = class=3D"">rrs@freebsd.org</a>> wrote:<br class=3D""><blockquote = type=3D"cite" class=3D""><br class=3D"">The branch main has been updated = by rrs:<br class=3D""><br class=3D"">URL: <a = href=3D"https://www.google.com/url?q=3Dhttps://cgit.FreeBSD.org/src/commit= /?id%3D73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f&source=3Dgmail-imap&am= p;ust=3D1685311614000000&usg=3DAOvVaw0HmtU6ylNo8jRrPgvtzIB0" = class=3D"">https://www.google.com/url?q=3Dhttps://cgit.FreeBSD.org/src/com= mit/?id%3D73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f&source=3Dgmail-imap= &ust=3D1685311614000000&usg=3DAOvVaw0HmtU6ylNo8jRrPgvtzIB0</a><br = class=3D""><br class=3D"">commit = 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f<br class=3D"">Author: = Randall Stewart <<a = href=3D"mailto:rrs@FreeBSD.org" class=3D"">rrs@FreeBSD.org</a>><br = class=3D"">AuthorDate: 2023-04-01 05:46:38 +0000<br class=3D"">Commit: = Randall Stewart <<a = href=3D"mailto:rrs@FreeBSD.org" class=3D"">rrs@FreeBSD.org</a>><br = class=3D"">CommitDate: 2023-04-01 05:46:38 +0000<br class=3D""><br = class=3D""> Fixes in the tcp infrastructure with = respect to stack changes as well as other infrastructure updates for = incoming rack features.<br class=3D""><br class=3D""> = So stack switching as always been a bit of a issue. We = currently use a break before make setup which means that<br class=3D""> = if something goes wrong you have to try to get back to = a stack. This patch among a lot of other things changes that so<br = class=3D""> that it is a make before break. We also = expand some of the function blocks in prep for new features in rack that = will allow<br class=3D""> more controlled pacing. We = also add other abilities such as the pathway for a stack to query a = previous stack to acquire from<br class=3D""> it = critical state information so things in flight don't get dropped or = mis-handled when switching stacks. We also add the<br class=3D""> = concept of a timer granularity. This allows an = alternate stack to change from the old ticks granularity to microseconds = and<br class=3D""> of course this even gives us a = pathway to go to nanosecond timekeeping if we need to (something for the = data center to consider<br class=3D""> for sure).<br = class=3D""><br class=3D""> Once all this lands I will = then update rack to begin using all these new features.<br class=3D""><br = class=3D""> Reviewed by: tuexen<br class=3D""> = Sponsored by: Netflix Inc<br class=3D""> = Differential Revision: <a = href=3D"https://www.google.com/url?q=3Dhttps://reviews.freebsd.org/D39210&= amp;source=3Dgmail-imap&ust=3D1685311614000000&usg=3DAOvVaw1ZouYiM= ywAnpdYyYCp9T9O" = class=3D"">https://www.google.com/url?q=3Dhttps://reviews.freebsd.org/D392= 10&source=3Dgmail-imap&ust=3D1685311614000000&usg=3DAOvVaw1Zou= YiMywAnpdYyYCp9T9O</a><br class=3D""></blockquote><br class=3D"">Hi,<br = class=3D""><br class=3D"">Could you hide some stuff in netinet/tcp.h?<br = class=3D"">struct http_req breaks curl 8.1.0.<br class=3D""><br = class=3D"">Antoine<br class=3D""></blockquote><br class=3D"">Please = refer to Bug 271526 [1], especially Comment 4 [2] by Jonathan<br = class=3D"">Reynolds.<br class=3D"">A patch is proposed there inline (not = as an attachment).<br class=3D""><br class=3D"">[1] <a = href=3D"https://www.google.com/url?q=3Dhttps://bugs.freebsd.org/bugzilla/s= how_bug.cgi?id%3D271526&source=3Dgmail-imap&ust=3D1685311614000000= &usg=3DAOvVaw2e-0D0bz7CAIVj6kvLZOJg" = class=3D"">https://www.google.com/url?q=3Dhttps://bugs.freebsd.org/bugzill= a/show_bug.cgi?id%3D271526&source=3Dgmail-imap&ust=3D1685311614000= 000&usg=3DAOvVaw2e-0D0bz7CAIVj6kvLZOJg</a><br class=3D""><br = class=3D"">[2] <a = href=3D"https://www.google.com/url?q=3Dhttps://bugs.freebsd.org/bugzilla/s= how_bug.cgi?id%3D271526%23c4&source=3Dgmail-imap&ust=3D16853116140= 00000&usg=3DAOvVaw154j12MkBXKn2z9_gepR1n" = class=3D"">https://www.google.com/url?q=3Dhttps://bugs.freebsd.org/bugzill= a/show_bug.cgi?id%3D271526%23c4&source=3Dgmail-imap&ust=3D16853116= 14000000&usg=3DAOvVaw154j12MkBXKn2z9_gepR1n</a><br class=3D""><br = class=3D"">-- <br class=3D"">Tomoaki AOKI <<a = href=3D"mailto:junchoon@dec.sakura.ne.jp" = class=3D"">junchoon@dec.sakura.ne.jp</a>><br = class=3D""></div></div></blockquote></div><br class=3D""><div class=3D""> <div style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: normal; letter-spacing: normal; = orphans: auto; text-align: start; text-indent: 0px; text-transform: = none; white-space: normal; widows: auto; word-spacing: 0px; = -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; = text-decoration: none;">------</div><div style=3D"caret-color: rgb(0, 0, = 0); color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; = font-style: normal; font-variant-caps: normal; font-weight: normal; = letter-spacing: normal; orphans: auto; text-align: start; text-indent: = 0px; text-transform: none; white-space: normal; widows: auto; = word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; text-decoration: none;">Randall = Stewart</div><div style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, = 0); font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: normal; letter-spacing: normal; = orphans: auto; text-align: start; text-indent: 0px; text-transform: = none; white-space: normal; widows: auto; word-spacing: 0px; = -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; = text-decoration: none;"><a href=3D"mailto:rrs@netflix.com" = class=3D"">rrs@netflix.com</a></div><div style=3D"caret-color: rgb(0, 0, = 0); color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; = font-style: normal; font-variant-caps: normal; font-weight: normal; = letter-spacing: normal; orphans: auto; text-align: start; text-indent: = 0px; text-transform: none; white-space: normal; widows: auto; = word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D""><br = class=3D""></div><br class=3D"Apple-interchange-newline"> </div> <br class=3D""></body></html>= --Apple-Mail=_2CFBEC81-0A8F-4100-92B3-C15C10F11BC2-- --Apple-Mail=_1025A52E-98E4-4DB8-85E6-BD39C353D7B1 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCAzYw ggMyMIICGqADAgECAgqxywKqrHPB2ybTMA0GCSqGSIb3DQEBCwUAMEcxGDAWBgNVBAMTD1JhbmRh bGwgU3Rld2FydDEeMBwGCSqGSIb3DQEJARYPcnJzQG5ldGZsaXguY29tMQswCQYDVQQGEwJVUzAe Fw0yMTAxMjQxMjIwMTRaFw0yNjAxMjQxMjIwMTRaMEcxGDAWBgNVBAMTD1JhbmRhbGwgU3Rld2Fy dDEeMBwGCSqGSIb3DQEJARYPcnJzQG5ldGZsaXguY29tMQswCQYDVQQGEwJVUzCCASIwDQYJKoZI hvcNAQEBBQADggEPADCCAQoCggEBAMUAht2nr/NFlK+tmmN9PdO3DBPfeYh9fLcbVihR+/dipO41 AsFy9y+2uDVaFhTEvp406P0o9PQQTuYXqrCr76eWQIj3V787e1WKjTup1mIyQeWHGf1gvb/7vmI2 zHg6QZEIC4W8xeO8SLKyHiwlFHZn8Rn1HxtB7Ge+NulygkgUgJYhXD5E29jVGXAc6Qn9Vr9AexPf KaOhHCaNB/Twcinayz6D8CO/Ym1LOs3+ceSOa4cB07fepmbqDSXDkOeA3U7KLaluHrRTlj6DO+JU nqKXX7jJ68KTYSZ0qH4fZsk8cxFkwYI/3HDJi+oF+FDkf7SRo1Q2w+e3M/5MReLIQ7sCAwEAAaMg MB4wDwYJKoZIhvcvAQEKBAIFADALBgNVHQ8EBAMCB4AwDQYJKoZIhvcNAQELBQADggEBAHJfum1j 1WIVFjOJT/hqMIN751aXkablmwesW94lNJKjslPULbbcP5nZGg2lGpHcZ+0I5F/1TTiEsT2H2rhA uAnSsUxTpxRA+aoe+xtJOa5vle3CprhFkHAvB7EIoLiNaPd0DNK6kKYsbvr5Z5Eq7TF3SIO77Qh9 /8VgUfOb0ARDgix59Q6MM0NmIabEwh0cDWQYlGgDDtN9DNk5PGM4pjs48suwEdLmFTMOmGTkCp7I Vq6iHDNinBiB6+BB4VYMAO1o9qS+0pnfdmPJybt0zVGrhm/c1Fmm3Jec7NEuiKeXmhPIwdwMkKyp AsX0sHuFCYwioBTHHZpvnir+H2rRakgxggHrMIIB5wIBATBVMEcxGDAWBgNVBAMTD1JhbmRhbGwg U3Rld2FydDEeMBwGCSqGSIb3DQEJARYPcnJzQG5ldGZsaXguY29tMQswCQYDVQQGEwJVUwIKscsC qqxzwdsm0zANBglghkgBZQMEAgEFAKBpMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZI hvcNAQkFMQ8XDTIzMDUyMzEzNTkzM1owLwYJKoZIhvcNAQkEMSIEIAbYQb7fTKF4Pexr1QJC+70g qQOunEr+EdpzNVV8zuEbMA0GCSqGSIb3DQEBCwUABIIBAKPBGO7X26mbuaKxnYl6ivOAtrO61moD G3s+Z3B9J7huKiT2fMnxDHLnir/Pj4VcYBJKzuI/nEgs5Y8TlP6+rrqjlUKkFckb7poGFyFt3uSK lz8tVA8dheiVisoIt4nOX6zQN/WyeCvp97oHT8KCjf2AQx4ms1DaeZldH5qCTF0kZKhXF6dHX3ET IYTtSHtZqLRh30Ibj2BFqlIKGaTGGuBVaE+kqLNk4RmG7zhSX1nu+JnJvffdERVZz6Jo7nioB+J5 0OudZOgqvOFCrd3JinhelYQg8mPjqc3VxO2poiYcEYOSHiWj1npnxn5dPCA72f/hsh1NOwITBDBK 2uvCCTYAAAAAAAA= --Apple-Mail=_1025A52E-98E4-4DB8-85E6-BD39C353D7B1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1E5C3216-1A6F-43AC-AA91-24FA1EA18842>