From owner-freebsd-arm@FreeBSD.ORG  Wed May 13 15:19:49 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 93C85420
 for <freebsd-arm@freebsd.org>; Wed, 13 May 2015 15:19:49 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 74C9D1952
 for <freebsd-arm@freebsd.org>; Wed, 13 May 2015 15:19:49 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t4DFJnwu061664
 for <freebsd-arm@freebsd.org>; Wed, 13 May 2015 15:19:49 GMT
 (envelope-from daemon-user@phabric-backend.isc.freebsd.org)
Received: (from daemon-user@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t4DFJnfS061663;
 Wed, 13 May 2015 15:19:49 GMT (envelope-from daemon-user)
Date: Wed, 13 May 2015 15:19:49 +0000
To: freebsd-arm@freebsd.org
From: "zbb (Zbigniew Bodek)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D2377: Introduce ARM GICv3 support
Message-ID: <168a6580eb08d5034914148eb73e5c56@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2377: Introduce ARM GICv3 support
X-Herald-Rules: <28>, <31>, <32>, <34>, <8>
X-Phabricator-To: <PHID-USER-6m5mo2kjikkzyd33ld4n>
X-Phabricator-To: <PHID-USER-yhwnadxnjthofqelhkdx>
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-pkmvihbtt3lba2qkphcz>
X-Phabricator-To: <PHID-USER-cc6daxnrb232k4sqvkvg>
X-Phabricator-To: <PHID-USER-nhm2a2j4zvuftar7szlp>
X-Phabricator-Cc: <PHID-USER-2wocyy2vsyzu2nddvuw6>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org>
Thread-Index: MjA1ZGZkZWI5MTE4ZDk2Nzk0YzAyZGRiMWRiIFVTa5U=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2015 15:19:49 -0000

zbb added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3.c:321 DELAY is because we if fact expect to get immediate response from GIC. If we don't get any this most probably means malfunction. I would suggest to wait that second and panic instead of device_printf(). I don't have any good explanation why 1 second and not for example 0.5. There are no timing details in the GIC documentation related to that and the one below so this value was based on what Linux code does.

REVISION DETAIL
  https://reviews.freebsd.org/D2377

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, ian, emaste, andrew, imp, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm