From owner-cvs-src@FreeBSD.ORG Wed Feb 18 11:03:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6649916A4CE; Wed, 18 Feb 2004 11:03:06 -0800 (PST) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 825C143D1D; Wed, 18 Feb 2004 11:03:04 -0800 (PST) (envelope-from ru@ip.net.ua) Received: from ru.office.ipnet (ws-80.office.ipnet [10.71.1.80]) by tigra.ip.net.ua (8.12.10/8.12.9) with ESMTP id i1IJ5YId070355 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 18 Feb 2004 21:05:34 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by ru.office.ipnet (8.12.10/8.12.10/Submit) id i1IJ2tsE001749; Wed, 18 Feb 2004 21:02:55 +0200 (EET) (envelope-from ru) Date: Wed, 18 Feb 2004 21:02:55 +0200 From: Ruslan Ermilov To: "Andrey A. Chernov" Message-ID: <20040218190255.GB1578@ip.net.ua> References: <200402170538.i1H5cjQa010622@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline In-Reply-To: <200402170538.i1H5cjQa010622@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/usr.bin/binutils/gasp Makefile src/gnu/usr.bin/binutils/gdb Makefile src/gnu/usr.bin/cvs/cvs Makefile src/gnu/usr.bin/cvs/lib Makefile src/gnu/usr.bin/cvs/libdiff Makefile src/gnu/usr.bin/diff Makefile src/gnu/usr.bin/grep Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2004 19:03:06 -0000 --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 16, 2004 at 09:38:45PM -0800, Andrey A. Chernov wrote: > ache 2004/02/16 21:38:45 PST >=20 > FreeBSD src repository >=20 > Modified files: > gnu/usr.bin/binutils/gasp Makefile=20 > gnu/usr.bin/binutils/gdb Makefile=20 > gnu/usr.bin/cvs/cvs Makefile=20 > gnu/usr.bin/cvs/lib Makefile=20 > gnu/usr.bin/cvs/libdiff Makefile=20 > gnu/usr.bin/diff Makefile=20 > gnu/usr.bin/grep Makefile=20 > Log: > Oops, use -I${DESTDIR}/usr/include/gnu instead of ... /../../include/gnu > =20 > Revision Changes Path > 1.14 +1 -1 src/gnu/usr.bin/binutils/gasp/Makefile > 1.75 +1 -1 src/gnu/usr.bin/binutils/gdb/Makefile > 1.44 +1 -1 src/gnu/usr.bin/cvs/cvs/Makefile > 1.25 +1 -2 src/gnu/usr.bin/cvs/lib/Makefile > 1.8 +1 -2 src/gnu/usr.bin/cvs/libdiff/Makefile > 1.16 +1 -1 src/gnu/usr.bin/diff/Makefile > 1.28 +1 -1 src/gnu/usr.bin/grep/Makefile >=20 This is bogus. The correct way would be to fix #include's to spell ``#include '', but this will be considered evil as it will take lot of files off their vendor branches. What was wrong with ${.CURDIR}/.../include/gnu, except misspelling the number of ".."'s in some cases? I've been slowly working towards removing all instances of -I${DESTDIR}/usr/include/... in the src/ makefiles. Before this commit, there were only a few makefiles with -I${DESTDIR}/usr/include/rpcsvc, but RPC code is known to be a nightmare to deal with. Cheers, --=20 Ruslan Ermilov FreeBSD committer ru@FreeBSD.org --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAM7bfUkv4P6juNwoRAi+LAJ4y5BlP4M0NS7kTcAflkkGh6DoQbQCfSaU7 bP/l1WYO01Qcx/Ac07vpKXc= =qUfv -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn--