From owner-svn-src-all@FreeBSD.ORG  Tue Apr 26 13:37:48 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1659A106566C;
	Tue, 26 Apr 2011 13:37:48 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id C89698FC16;
	Tue, 26 Apr 2011 13:37:47 +0000 (UTC)
Received: from [10.0.0.63] (63.imp.bsdimp.com [10.0.0.63])
	(authenticated bits=0)
	by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p3QDRBK5033584
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO);
	Tue, 26 Apr 2011 07:27:11 -0600 (MDT) (envelope-from imp@bsdimp.com)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <1303811835.49968.6.camel@buffy.york.ac.uk>
Date: Tue, 26 Apr 2011 07:27:11 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <67269B04-5727-4B8D-B442-D93CD0CB0A61@bsdimp.com>
References: <201104260409.p3Q49KaJ006272@svn.freebsd.org>
	<1303811835.49968.6.camel@buffy.york.ac.uk>
To: Gavin Atkinson <gavin@FreeBSD.org>
X-Mailer: Apple Mail (2.1084)
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(harmony.bsdimp.com [10.0.0.6]);
	Tue, 26 Apr 2011 07:27:11 -0600 (MDT)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, "David E. O'Brien" <obrien@FreeBSD.org>
Subject: Re: svn commit: r221053 - head/usr.bin/rlogin
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2011 13:37:48 -0000


On Apr 26, 2011, at 3:57 AM, Gavin Atkinson wrote:

> On Tue, 2011-04-26 at 04:09 +0000, David E. O'Brien wrote:
>> Author: obrien
>> Date: Tue Apr 26 04:09:20 2011
>> New Revision: 221053
>> URL: http://svn.freebsd.org/changeset/base/221053
>>=20
>> Log:
>>  This builds OK using the parent dir's WARNS=3D6.
>>  [built on both AMD64 and i386]
>=20
> As a general rule, just compiling on i386 and amd64 are not sufficient
> to test WARNS bumps.  It's usually sufficient to also crossbuild to a
> platform like sparc64 which has stricter alignment, but for a full =
test
> a "make universe" is best, as this will also catch other issues (for
> example arm, where char is unsigned).

I read the test log as "not really tested, feel free to back it out if =
it fails on a different architecture"

:)

Warner