From owner-freebsd-bugs@FreeBSD.ORG Mon Sep 13 06:40:43 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12BD616A4CE for ; Mon, 13 Sep 2004 06:40:43 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1DB443D1D for ; Mon, 13 Sep 2004 06:40:42 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8D6egsp046087 for ; Mon, 13 Sep 2004 06:40:42 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8D6egph046086; Mon, 13 Sep 2004 06:40:42 GMT (envelope-from gnats) Date: Mon, 13 Sep 2004 06:40:42 GMT Message-Id: <200409130640.i8D6egph046086@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Dan Lukes Subject: Re: bin/71630: [PATCH] cleanup of the usr.sbin/pppd code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2004 06:40:43 -0000 The following reply was made to PR bin/71630; it has been noted by GNATS. From: Dan Lukes To: Giorgos Keramidas Cc: bug-followup@freebsd.org Subject: Re: bin/71630: [PATCH] cleanup of the usr.sbin/pppd code Date: Mon, 13 Sep 2004 08:35:58 +0200 Giorgos Keramidas wrote: > The impact is not greater than the impact of the bogus initialization > shown above though. Not true (v=v during declaration doesn't emit any code - it's signal for compiler, not real assignment). > The only difference is the extra safety the NULL > initialization buys us. Agree. Lets initialise iffile to NULL Dan