From owner-freebsd-x11@FreeBSD.ORG  Fri Oct 31 09:00:02 2014
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
Delivered-To: x11@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EA24BBBD;
 Fri, 31 Oct 2014 09:00:02 +0000 (UTC)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 71B29EBA;
 Fri, 31 Oct 2014 09:00:02 +0000 (UTC)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id s9V8xvqB072271
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Fri, 31 Oct 2014 10:59:57 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua s9V8xvqB072271
Received: (from kostik@localhost)
 by tom.home (8.14.9/8.14.9/Submit) id s9V8xvI9072270;
 Fri, 31 Oct 2014 10:59:57 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Fri, 31 Oct 2014 10:59:57 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Tijl Coosemans <tijl@FreeBSD.org>
Subject: Re: [rfc] Radeon AGP support patches
Message-ID: <20141031085956.GN53947@kib.kiev.ua>
References: <20141026162442.1330d4c3@kalimero.tijl.coosemans.org>
 <20141027141631.GX1877@kib.kiev.ua>
 <20141027170055.10af15e6@kalimero.tijl.coosemans.org>
 <20141027162753.GB1877@kib.kiev.ua>
 <20141027221058.23a188d0@kalimero.tijl.coosemans.org>
 <20141029170329.GI53947@kib.kiev.ua>
 <20141030153130.4d8c441b@kalimero.tijl.coosemans.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141030153130.4d8c441b@kalimero.tijl.coosemans.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.0
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home
Cc: x11@FreeBSD.org, dumbbell@FreeBSD.org
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11/>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Oct 2014 09:00:03 -0000

On Thu, Oct 30, 2014 at 03:31:30PM +0100, Tijl Coosemans wrote:
> Thanks.  Just to be sure, did you review 2 & 4 as well?

Reasoning for the patch 2 seems to be correct. You mean the code from
drm_bufs.c:drm_addmap(), I suppose ? My reaction to the patch is the
question about maintanability of this approach, for future imports. If
all usage of map->handle must be reviewed for correctness, we should
switch to the Linux approach of making the handle useable for offset
calculation.

I suspect that it is used not only by drm1, but I do not know radeon
driver.

I think that the patch 4 is fine.