From owner-freebsd-current@freebsd.org Tue Dec 17 00:06:22 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4F7F61D24F9 for ; Tue, 17 Dec 2019 00:06:22 +0000 (UTC) (envelope-from nomadlogic@gmail.com) Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47cJMd3d3Zz4V1W for ; Tue, 17 Dec 2019 00:06:21 +0000 (UTC) (envelope-from nomadlogic@gmail.com) Received: by mail-vk1-xa33.google.com with SMTP id t129so2176229vkg.6 for ; Mon, 16 Dec 2019 16:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=32stl2fsx+v6QB6l0s3vhKG6yUYSqFuz+0Aok07u3Yo=; b=NG5THIPu7phxkOUDp6C6TYusECKbOCvngbMDv55r6rO3ivHtzrru2tuqEYFj9mlCqV eynmAGdUkVpr+5XtM6n6NUUAq1zGdaOw/SSSZ8CqPb10ccMFj6T9orf+u4WykqzuhR9C 7/z3o0wgzNdyrCWQhn/SNHp5P5DvsTivDdYEZlaaKJGrPAh5h/3uPMf9cwHc0sP2/T7w C0Z0fR7silQJJNlslFuhjt2YsSG/TJcCIh+9UKXOShoYe7lmAnJbi5itQ7KNLd1TABqY Z/WmKgzmbesu/4TEiNe3LAq1qJfcmjGB9FzktBkNT9lpdUvrHS23qZsEDKFYzASL5DaD Gn2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=32stl2fsx+v6QB6l0s3vhKG6yUYSqFuz+0Aok07u3Yo=; b=X097acBnjB95BU++wMtZ002PWcKH1jcucoIz2e39ea6KsPmY8XmRwnLbOjTVO8ZC35 ey8CzQD6+7e8dD+X18izPYqMvR+fL3U3rTSS6Ttb9ARziDUVukMN3Ymj1wqk6zBKynNV at81Q7ZaJgxXyLEH4fafPFNeWSZtYoqzp4B4B8kDTowy3r4W4XOfPldX19qTcAeNNdO9 SWxpdTKWSqsaCtYO46QeK5aMNSklqMACw39XsDnPgHt9SAjP84G1kB3reH7Wb6mBJ/aO 5vMNu44aX3TVHEoSY0dKJlT92PggbqlMUr1zDB8R+P9Lx7uqhvo0FX/8wLDeKDwqiWOE pdog== X-Gm-Message-State: APjAAAWhWWdem1MgBOeIXGuVmTGcLbSmI3Ymgg++wVGi9wdyYBcLIj2M O0wHJsaR7B29qVl2Ef5KKkIukKUkTxAnM2GVI5PyUg== X-Google-Smtp-Source: APXvYqyHxXztWfSDPasNGP6lx+nY5DS5ao3HAAR4MkXOSUTkerpTKk+nHiPJsCPgnsx9gXVg/isM+bfw0Fvt60UBjMw= X-Received: by 2002:ac5:c64c:: with SMTP id j12mr1301069vkl.11.1576541180018; Mon, 16 Dec 2019 16:06:20 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: pete wright Date: Mon, 16 Dec 2019 16:06:08 -0800 Message-ID: Subject: Re: error building scsi_da.c with recent current To: Warner Losh Cc: FreeBSD Current X-Rspamd-Queue-Id: 47cJMd3d3Zz4V1W X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=NG5THIPu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of nomadlogic@gmail.com designates 2607:f8b0:4864:20::a33 as permitted sender) smtp.mailfrom=nomadlogic@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[3.3.a.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; IP_SCORE(0.00)[ip: (-9.44), ipnet: 2607:f8b0::/32(-2.19), asn: 15169(-1.90), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Dec 2019 00:06:22 -0000 no worries - and thanks for the workaround. i'm going to take a look before i sign-off for the night, hopefully github will be in sync by then. cheers, -pete On Mon, Dec 16, 2019 at 3:15 PM Warner Losh wrote: > The prior version (r355814) works just fine, if you wanted to get going... > Sorry for the hassle.. I'm flushing my WIP trees, deleting old stuff and > forgot this change had a dependency on something that's not quite ready yet. > > Warner > > On Mon, Dec 16, 2019 at 4:12 PM pete wright wrote: > >> Thanks, maybe git mirror was lagging will test in a bit. >> >> Thanks! >> -pete >> >> On Mon, Dec 16, 2019, 3:09 PM Warner Losh wrote: >> >>> Update. That version was in place for about an hour before I fixed it. >>> r355815 broke it and r355818 fixed it. >>> >>> Warner >>> >>> >>> On Mon, Dec 16, 2019 at 3:27 PM pete wright >>> wrote: >>> >>>> here's the error i'm getting when building: >>>> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:28: error: >>>> expected >>>> identifier >>>> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >>>> ^ >>>> /usr/home/pete/git/freebsd/sys/sys/sysctl.h:126:18: note: expanded from >>>> macro 'OID_AUTO' >>>> #define OID_AUTO (-1) >>>> ^ >>>> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:1: error: type >>>> specifier missing, defaults to 'int' [-Werror,-Wimplicit-int] >>>> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >>>> ^ >>>> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:13: error: this >>>> function declaration is not a prototype [-Werror,-Wstrict-prototypes] >>>> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >>>> ^ >>>> 3 errors generated. >>>> *** [scsi_da.o] Error code 1 >>>> >>>> >>>> >>>> might be this commit? >>>> commit 5fa79c6768be78d78815156f8ecf50cb2008233f (HEAD -> master, >>>> origin/master, origin/HEAD) >>>> Author: imp >>>> Date: Mon Dec 16 18:16:44 2019 +0000 >>>> >>>> Implement a system-wide limit or da and ada devices for delete. >>>> >>>> Excesively large TRIMs can result in timeouts, which cause big >>>> problems. Limit trims to 1GB to mititgate these issues. >>>> >>>> Reviewed by: scottl >>>> Differential Revision: https://reviews.freebsd.org/D22809 >>>> >>>> >>>> >>>> if there is any additional info needed happy to provide it. >>>> >>>> cheers, >>>> -pete >>>> >>>> -- >>>> pete wright >>>> www.nomadlogic.org >>>> @nomadlogicLA >>>> _______________________________________________ >>>> freebsd-current@freebsd.org mailing list >>>> https://lists.freebsd.org/mailman/listinfo/freebsd-current >>>> To unsubscribe, send any mail to " >>>> freebsd-current-unsubscribe@freebsd.org" >>>> >>> -- pete wright www.nomadlogic.org @nomadlogicLA