From owner-freebsd-ports@FreeBSD.ORG Thu Aug 7 00:27:18 2014 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B977C9B9 for ; Thu, 7 Aug 2014 00:27:18 +0000 (UTC) Received: from astart2.astart.com (108-248-95-193.lightspeed.sndgca.sbcglobal.net [108.248.95.193]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 93D4A21BF for ; Thu, 7 Aug 2014 00:27:17 +0000 (UTC) Received: from laptop_84.private (localhost [127.0.0.1]) by astart2.astart.com (8.14.4/8.14.4) with ESMTP id s770RExB022645; Wed, 6 Aug 2014 17:27:14 -0700 (PDT) (envelope-from papowell@astart.com) Message-ID: <53E2C7E3.1060009@astart.com> Date: Wed, 06 Aug 2014 17:27:15 -0700 From: Patrick Powell Reply-To: papowell@astart.com Organization: Astart Technologies User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130714 Thunderbird/17.0.7 MIME-Version: 1.0 To: olli hauer Subject: Re: Apache 24 + mod_perl References: <53DC01F2.90102@astart.com> <20140801213432.GC2644@home.opsec.eu> <53DE5457.90007@gmx.de> <53DEA5F8.40204@astart.com> <53E293EE.60100@astart.com> <53E29F63.4020507@gmx.de> In-Reply-To: <53E29F63.4020507@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: ports@freebsd.org, "modperl@perl.apache.org" , Kurt Jaeger , Steve Hay X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Aug 2014 00:27:18 -0000 On 08/06/14 14:34, olli hauer wrote: > On 2014-08-06 22:45, Patrick Powell wrote: >> On 08/06/14 00:19, Steve Hay wrote: >>> On 3 August 2014 22:13, Patrick Powell wrote: >>>> On 08/03/14 08:25, olli hauer wrote: >>>>> On 2014-08-01 23:34, Kurt Jaeger wrote: >>>>>> Hi! >>>>>> >>>>>>> Question: when will mod_perl be available for Apache 24? >>>>>> There's a PR where people are discussing this: >>>>>> >>>>>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191471 >>>>>> >>>>>> This PR needs more testers etc. >>>>>> >>>>> I've updated the PR with a patch against the latest mod_perl trunk >>>>> revision (r1602105). >>>>> >>>>> The patch against the port can be grabbed from here or from our bugzilla >>>>> >>>>> http://people.freebsd.org/~ohauer/diffs/apache/mod_perl2-2.0.8_apache24.diff >>>>> >>>>> Please test *at own risk*, and report issues to upstream and here so we >>>>> can integrate fresh upstream fixes and update the port. >>>>> >>>>> The first proposed patch will allows the port to build but I have to many >>>>> concerns for integrating this simple fix into the tree. >>>>> I don't believe the first patch on the PR will work right else it would >>>>> take the upstream dev. work and time for mod_perl2 at absurdI -um ... >>>>> >>>>> >>>> I have taken a slightly different approach, using the mod_perl2 SVN >>>> ..../httpd24 branch as the starting point. >>>> >>> The httpd24 branch is obselete. It was used for the initial >>> development of httpd-2.4 support, but was superseded by >>> httpd24threading, and since then everything from both branches has >>> been merged back to trunk. >>> >>> The current trunk is largely ready for a 2.0.9 release supporting >>> httpd-2.4, pending some more testing and fixes as necessary. >>> >> I tried using the trunk a couple of days ago and it did not compile. Just to make sure >> that I am using the right SVN respository and branch, what is the URL of the trunk SVN repository? >> I am more than happy to try testing mod_perl. >> > Hm, with the following patch applied to www/mod_perl2 it builds fine for me on FreeBSD 8.4 / 10.0 (amd64) an apache-2.4.10 > http://people.freebsd.org/~ohauer/diffs/apache/mod_perl2-2.0.8_apache24.diff > > The patch does some adjustments in the port / pkg-plist and fetches a complete archive containing all patches so the sources are the same as the upstream (r1602105) trunk/httpd24threade branch. > > After applying the patch and using the command `make patch' it is easy to compare the sources against upstream sources (check out before) > http://svn.apache.org/repos/asf/perl/modperl/branches/httpd24threading > http://svn.apache.org/repos/asf/perl/modperl/trunk > > > Easiest way to apply the patch against the unmodified port: > > $ cd www/mod_perl2 > $ fetch http://people.freebsd.org/~ohauer/diffs/apache/mod_perl2-2.0.8_apache24.diff > $ patch -p1 < mod_perl2-2.0.8_apache24.diff > > PS: > I've updated the patch because it needs some additional handling for pkg-plist if build against apache-2.2.x (Provider.pm/Provider.so) > > I tried your procedure (see above). The patch applied, I was able to compile the mod_perl, and 'make test' ran and it passed all of the critical tests. I then ran some more of my tests for the functionality it used. These passed. I would say that unless somebody else comes up with a problem that I would use this as a baseline for distribution/installation. That is, I would put up the modified Makefile, with a warning, but would allow people to make/install it by specifying an option such as "make IGNORE_WARNING=yes" Of course, the FreeBSD Ports team may have different views on this... but until the upstream mod_perl team puts out mod_perl-2.0.9 officially I think that this is the best we can do. Also, some more testers will be able to try it out and report any problems....