From owner-cvs-src@FreeBSD.ORG Fri Jun 6 20:56:47 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3F671065682; Fri, 6 Jun 2008 20:56:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 52D648FC1F; Fri, 6 Jun 2008 20:56:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m56KtqcK015893; Fri, 6 Jun 2008 16:56:41 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: src-committers@freebsd.org Date: Fri, 6 Jun 2008 15:24:57 -0400 User-Agent: KMail/1.9.7 References: <200806061845.m56IjrsU075326@repoman.freebsd.org> In-Reply-To: <200806061845.m56IjrsU075326@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806061524.57417.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Fri, 06 Jun 2008 16:56:41 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7390/Fri Jun 6 13:50:38 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/smbus smb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2008 20:56:47 -0000 On Friday 06 June 2008 02:45:32 pm John Baldwin wrote: > jhb 2008-06-06 18:45:32 UTC > > FreeBSD src repository > > Modified files: > sys/dev/smbus smb.c > Log: > SVN rev 179625 on 2008-06-06 18:45:32Z by jhb > > - Store the device_t of the smbX device in the softc. > - Store the softc of the device in the 'si_drv1' of the cdev. > - Lookup the softc via 'si_drv1' in cdev methods rather than using the > minor number as a unit for devclass_get_softc(). > - Lookup the device_t via the softc field in cdev methods rather than > using the minor number as a unit for devclass_get_device(). > - Add a mutex to the softc to protect 'sc_opened'. > - Remove D_NEEDGIANT as all the smbus drivers are now MPSAFE and this driver > is now MPSAFE. > - Remove some checks for NULL softc pointers that can't happen and don't > bzero the softc during attach. All the smbus(4) stuff is MPSAFE now. I do plan to look at iic(4) soonish as it is similar in design to smbus(4). Once it is locked then if_ic(4) can be locked. -- John Baldwin