From owner-freebsd-virtualization@freebsd.org Tue Jul 7 14:51:30 2020 Return-Path: Delivered-To: freebsd-virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1EAF7364473 for ; Tue, 7 Jul 2020 14:51:30 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from tor1-11.mx.scaleengine.net (tor1-11.mx.scaleengine.net [IPv6:2001:470:1:474::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B1QPF5LDZz3Rfr for ; Tue, 7 Jul 2020 14:51:29 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (Seawolf.HML3.ScaleEngine.net [209.51.186.28]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by tor1-11.mx.scaleengine.net (Postfix) with ESMTPSA id A67C32875C for ; Tue, 7 Jul 2020 14:51:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.10.3 tor1-11.mx.scaleengine.net A67C32875C To: freebsd-virtualization@freebsd.org References: From: Allan Jude Autocrypt: addr=allanjude@freebsd.org; prefer-encrypt=mutual; keydata= xsFNBFVwZcYBEADwrZDH0xe0ZVjc9ORCc6PcBLwS/RTXA6NkvpD6ea02pZ8lPOVgteuuugFc D34LdDbiWr+479vfrKBh+Y38GL0oZ0/13j10tIlDMHSa5BU0y6ACtnhupFvVlQ57+XaJAb/q 7qkfSiuxVwQ3FY3PL3cl1RrIP5eGHLA9hu4eVbu+FOX/q/XVKz49HaeIaxzo2Q54572VzIo6 C28McX9m65UL5fXMUGJDDLCItLmehZlHsQQ+uBxvODLFpVV2lUgDR/0rDa0B9zHZX8jY8qQ7 ZdCSy7CwClXI054CkXZCaBzgxYh/CotdI8ezmaw7NLs5vWNTxaDEFXaFMQtMVhvqQBpHkfOD 7rjjOmFw00nJL4FuPE5Yut0CPyx8vLjVmNJSt/Y8WxxmhutsqJYFgYfWl/vaWkrFLur/Zcmz IklwLw35HLsCZytCN5A3rGKdRbQjD6QPXOTJu0JPrJF6t2xFkWAT7oxnSV0ELhl2g+JfMMz2 Z1PDmS3NRnyEdqEm7NoRGXJJ7bgxDbN+9SXTyOletqGNXj/bSrBvhvZ0RQrzdHAPwQUfVSU2 qBhQEi2apSZstgVNMan0GUPqCdbE2zpysg+zT7Yhvf9EUQbzPL4LpdK1llT9fZbrdMzEXvEF oSvwJFdV3sqKmZc7b+E3PuxK6GTsKqaukd/3Cj8aLHG1T1im1QARAQABzSJBbGxhbiBKdWRl IDxhbGxhbmp1ZGVAZnJlZWJzZC5vcmc+wsF/BBMBAgApBQJVcGXGAhsjBQkSzAMABwsJCAcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQGZU1PhKYC34Muw/+JOKpSfhhysWFYiRXynGRDe07 Z6pVsn7DzrPUMRNZfHu8Uujmmy3p2nx9FelIY9yjd2UKHhug+whM54MiIFs90eCRVa4XEsPR 4FFAm0DAWrrb7qhZFcE/GhHdRWpZ341WAElWf6Puj2devtRjfYbikvj5+1V1QmDbju7cEw5D mEET44pTuD2VMRJpu2yZZzkM0i+wKFuPxlhqreufA1VNkZXI/rIfkYWK+nkXd9Efw3YdCyCQ zUgTUCb88ttSqcyhik/li1CDbXBpkzDCKI6I/8fAb7jjOC9LAtrZJrdgONywcVFoyK9ZN7EN AVA+xvYCmuYhR/3zHWH1g4hAm1v1+gIsufhajhfo8/wY1SetlzPaYkSkVQLqD8T6zZyhf+AN bC7ci44UsiKGAplB3phAXrtSPUEqM86kbnHg3fSx37kWKUiYNOnx4AC2VXvEiKsOBlpyt3dw WQbOtOYM+vkfbBwDtoGOOPYAKxc4LOIt9r+J8aD+gTooi9Eo5tvphATf9WkCpl9+aaGbSixB tUpvQMRnSMqTqq4Z7DeiG6VMRQIjsXDSLJEUqcfhnLFo0Ko/RiaHd5xyAQ4DhQ9QpkyQjjNf /3f/dYG7JAtoD30txaQ5V8uHrz210/77DRRX+HJjEj6xCxWUGvQgvEZf5XXyxeePvqZ+zQyT DX61bYw6w6bOwU0EVXBlxgEQAMy7YVnCCLN4oAOBVLZ5nUbVPvpUhsdA94/0/P+uqCIh28Cz ar56OCX0X19N/nAWecxL4H32zFbIRyDB2V/MEh4p9Qvyu/j4i1r3Ex5GhOT2hnit43Ng46z5 29Es4TijrHJP4/l/rB2VOqMKBS7Cq8zk1cWqaI9XZ59imxDNjtLLPPM+zQ1yE3OAMb475QwN UgWxTMw8rkA7CEaqeIn4sqpTSD5C7kT1Bh26+rbgJDZ77D6Uv1LaCZZOaW52okW3bFbdozV8 yM2u+xz2Qs8bHz67p+s+BlygryiOyYytpkiK6Iy4N7FTolyj5EIwCuqzfk0SaRHeOKX2ZRjC qatkgoD/t13PNT38V9tw3qZVOJDS0W6WM8VSg+F+bkM9LgJ8CmKV+Hj0k3pfGfYPOZJ/v18i +SmZmL/Uw2RghnwDWGAsPCKu4uZR777iw7n9Io6Vfxndw2dcS0e9klvFYoaGS6H2F13Asygr WBzFNGFQscN4mUW+ZYBzpTOcHkdT7w8WS55BmXYLna+dYer9/HaAuUrONjujukN4SPS1fMJ2 /CS/idAUKyyVVX5vozoNK2JVC1h1zUAVsdnmhEzNPsvBoqcVNfyqBFROEVLIPwq+lQMGNVjH ekLTKRWf59MEhUC2ztjSKkGmwdg73d6xSXMuq45EgIJV2wPvOgWQonoHH/kxABEBAAHCwWUE GAECAA8FAlVwZcYCGwwFCRLMAwAACgkQGZU1PhKYC34w5A//YViBtZyDV5O+SJT9FFO3lb9x Zdxf0trA3ooCt7gdBkdnBM6T5EmjgVZ3KYYyFfwXZVkteuCCycMF/zVw5eE9FL1+zz9gg663 nY9q2F77TZTKXVWOLlOV2bY+xaK94U4ytogOGhh9b4UnQ/Ct3+6aviCF78Go608BXbmF/GVT 7uhddemk7ItxM1gE5Hscx3saxGKlayaOsdPKeGTVJCDEtHDuOc7/+jGh5Zxpk/Hpi+DUt1ot 8e6hPYLIQa4uVx4f1xxxV858PQ7QysSLr9pTV7FAQ18JclCaMc7JWIa3homZQL/MNKOfST0S 2e+msuRwQo7AnnfFKBUtb02KwpA4GhWryhkjUh/kbVc1wmGxaU3DgXYQ5GV5+Zf4kk/wqr/7 KG0dkTz6NLCVLyDlmAzuFhf66DJ3zzz4yIo3pbDYi3HB/BwJXVSKB3Ko0oUo+6/qMrOIS02L s++QE/z7K12CCcs7WwOjfCYHK7VtE0Sr/PfybBdTbuDncOuAyAIeIKxdI2nmQHzl035hhvQX s4CSghsP319jAOQiIolCeSbTMD4QWMK8RL/Pe1FI1jC3Nw9s+jq8Dudtbcj2UwAP/STUEbJ9 5rznzuuhPjE0e++EU/RpWmcaIMK/z1zZDMN+ce2v1qzgV936ZhJ3iaVzyqbEE81gDxg3P+IM kiYh4ZtPB4Q= Subject: Re: bhyve, Windows guest and trim support Message-ID: <4e0c7427-8bb4-37d6-b717-181d5c9b66d3@freebsd.org> Date: Tue, 7 Jul 2020 10:51:24 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TOh9EVsdOfXdp6fBxAbexTLj7pbOMK1hM" X-Rspamd-Queue-Id: 4B1QPF5LDZz3Rfr X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; local_wl_from(0.00)[freebsd.org] X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2020 14:51:30 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TOh9EVsdOfXdp6fBxAbexTLj7pbOMK1hM Content-Type: multipart/mixed; boundary="kMiD2s1biVk0B0MRV2f7MOPwQH2rZP9eo"; protected-headers="v1" From: Allan Jude To: freebsd-virtualization@freebsd.org Message-ID: <4e0c7427-8bb4-37d6-b717-181d5c9b66d3@freebsd.org> Subject: Re: bhyve, Windows guest and trim support References: In-Reply-To: --kMiD2s1biVk0B0MRV2f7MOPwQH2rZP9eo Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2020-07-06 13:23, Andrea Venturoli wrote: > Hello. >=20 > I'm running zvol-backed Windows guests in bhyve on FreeBSD 12.1. > Over time, I see the zvol effectively used space grow in size: a sign > that Windows isn't trimming it. >=20 > I'm using virtio-blk: I guess this driver does not support trim? > I see reports that this support was added, but it's not clear to me > whether it's in the released version or not (I've downloaded the stable= > binary ISO from RedHat). > Is trim expected to work in such a scenario? > If not, is it a bhyve problem or a guest-driver problem (or both)? >=20 > I tried virtio-scsi, which should support trim, but the guest doesn't > even start in this case, getting stuck at the UEFI boot stage and endin= g > up in UEFI prompt. > Again, is this expected? > No guest driver has been loaded yet, so is it a bhyve limitation? > Is some tweak needed? >=20 > I tried changing from virtio-blk to ahci-hd: I was then able to manuall= y > trim the disk from inside the guest and recover a lot of space in the > zpool. > Alas ahci-hd is much slower, so I moved back to virtio-blk after that > (at least for the time being). >=20 > =C2=A0bye & Thanks > =C2=A0=C2=A0=C2=A0=C2=A0av. > _______________________________________________ > freebsd-virtualization@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-virtualization > To unsubscribe, send any mail to > "freebsd-virtualization-unsubscribe@freebsd.org" I added support for bhyve to understand virtio-blk TRIM messages to FreeBSD 13 back in April, r360229 It should be possible to apply that patch to FreeBSD 12.1, and then your Windows guest should be able to issue TRIM commands, and you will see the space become free in your zvol. There is a separate patch to teach the FreeBSD virtio-blk driver to send TRIM commands, it is still in review (needs testing on hypervisors other than bhyve): https://reviews.freebsd.org/D21708 --=20 Allan Jude --kMiD2s1biVk0B0MRV2f7MOPwQH2rZP9eo-- --TOh9EVsdOfXdp6fBxAbexTLj7pbOMK1hM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJfBIvvAAoJEBmVNT4SmAt+wXsP/iDDQTYB1OyMvxHqhr9Y6Bhy shBQOl2dKCa0QFsE667L2p3qaIp4FubXFZOOXIbLz6wV5PWHH29g6HEb2fuM0vO2 ToTMlXMTLyi4oCHHexZt24uU2mdASL0OJbnprUWR12HKvYSyvzlL7utHyaJTW08x Ma6CC0LRvbld+dppD+QmDkqfHuZazPXWMfgmRSNXDY73bUXKSVV9oD0gnRZIM+0N pZGRKyTbVqUyVPfJPSujBYr7JDPduPtwMHGFa1U1fHuKjFdlismf3pBXQnSQkJAm WlfdGaQhu7SaoI94rGUIGiwa/WMie9jD0nF6eP7uCbWK5LjuWN2xd8GpnN96z45I HhAkvnZNFfipGkg5x44uXFUwZ+wp8jZo+tpR3qMTGByNjfeunPmaZb+JlSpVXHtj QaWwfWf++ZGPfr9UrUgNNevoQiUGY9lWNklhqVVWbNrJQGcG/I2XFBqdUICvbaxT sfnlKOyMy/uiB4Kkdu0VrHf3IJdLFjPezA8rcsFU4v1drsjLpBke5TMNEcfyDFtO pyYdr8ZYcomDAwEkyxepWKVFHdhnqR4aPaeMQpZZ4K9azjPq0XBFKRDj3ojec1S3 ReNfmWInYLYJ96GBOW7XXEf96tKcXtHj9gTXSwVeb7Qsm8pKIKAvs4DxLj9bEYec pgP73JmY+g/hK9/OdEH+ =q2LU -----END PGP SIGNATURE----- --TOh9EVsdOfXdp6fBxAbexTLj7pbOMK1hM--