From owner-freebsd-wireless@FreeBSD.ORG Wed Jul 31 15:08:30 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 8F32724B for ; Wed, 31 Jul 2013 15:08:30 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wg0-x235.google.com (mail-wg0-x235.google.com [IPv6:2a00:1450:400c:c00::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 228BE272E for ; Wed, 31 Jul 2013 15:08:29 +0000 (UTC) Received: by mail-wg0-f53.google.com with SMTP id c11so723798wgh.32 for ; Wed, 31 Jul 2013 08:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=ftkn8Cxf7DFYOZeBK4UI5R9WmXGhEGVssQyrUrfnpME=; b=efREXIFRKa2EirHGUEp57AD2EwmuRBYT0hfcJoszU05jsqqovjNvKiD6LBDY4lOzkM kGCwcHWpnJljWW1ttBf/rqlQSQO3faz9GHtAHVlW6T/YA1rG5qc8I0xq6NiCLH1ngq6P USnIIC7941GARaRBYNiVxTNufiDeK8ZNDQSUqzDIFCGkz5EMsloKgwgjLxAAkwneXQR1 lgJjGDABjU0mzW7WMi7mLNyZGH2sU5NKk/5fwNij3kGha4EAVvFzjyxTyWxRR1NQULrS SA3VTuEzkbGlM3CqkOodHT1JWd5TqizpT1JSRCFFk+Q+klkXD0jSbXnvkiziFXW4fwqM lUDQ== MIME-Version: 1.0 X-Received: by 10.180.82.196 with SMTP id k4mr4742159wiy.0.1375283308294; Wed, 31 Jul 2013 08:08:28 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.94.132 with HTTP; Wed, 31 Jul 2013 08:08:28 -0700 (PDT) In-Reply-To: <002d01ce8c46$a13b23d0$e3b16b70$@info> References: <51f3f0ce.055a420a.2e1e.fffff220SMTPIN_ADDED_BROKEN@mx.google.com> <002d01ce8c46$a13b23d0$e3b16b70$@info> Date: Wed, 31 Jul 2013 08:08:28 -0700 X-Google-Sender-Auth: -MYQU4-5r8eIUuMXaoUOLZHahjk Message-ID: Subject: Re: [IWN] Reviw split 2 From: Adrian Chadd To: Cedric GROSS Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jul 2013 15:08:30 -0000 Hi, There's some more whitespace things to fix in your diff. - ->......>.......>.......bus_dmamap_sync(sc->rxq.data_dmat, data->map, ->......>.......>....... BUS_DMASYNC_POSTREAD); ->......>.......>.......DPRINTF(sc, IWN_DEBUG_ANY, +>......>.......>.......>.......DPRINTF(sc, IWN_DEBUG_ANY, >......>.......>....... "%s: scanning channel %d status %x\n", >......>.......>....... __func__, scan->chan, le32toh(scan->status)); .. notice how you've indented DPRINTF there? You should fix that. :) +#ifdef>IWN_DEBUG +#define IWN_DESC(x) case x:>...return #x +#define COUNTOF(array) (sizeof(array) / sizeof(array[0])) There should be a tab between the #define and the thing you're defining, rather than a space. + * This function print firmawre register .. typo, that should be "firmware" :) +>......}; +>......DPRINTF(sc, IWN_DEBUG_REGISTER, + "CSR values: (2nd byte of IWN_INT_COALESCING is IWN_INT_PERIODIC)%s", + "\n"); +>......for (i = 0; i < COUNTOF(csr_tbl); i++){ .. there needs to be a tab in front of the two lines after the DPRINTF(). Well, strictly speaking, there should be a tab (to bring it to the same indent level) and then four spaces (as it's a continuation of the line above it.) Now, you're making IWN_DEBUG an option, right? Once you've done this, I'll go make sure you can put it in the kernel config file as a build option (and I'll enable it by default on i386/amd64.) Thanks! -adrian