From owner-freebsd-ports@FreeBSD.ORG  Wed Mar  1 19:10:52 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@FreeBSD.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1C3AF16A420
	for <ports@FreeBSD.org>; Wed,  1 Mar 2006 19:10:52 +0000 (GMT)
	(envelope-from pauls@utdallas.edu)
Received: from smtp1.utdallas.edu (smtp1.utdallas.edu [129.110.10.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5635943D6A
	for <ports@FreeBSD.org>; Wed,  1 Mar 2006 19:10:46 +0000 (GMT)
	(envelope-from pauls@utdallas.edu)
Received: from utd59514.utdallas.edu (utd59514.utdallas.edu [129.110.3.28])
	by smtp1.utdallas.edu (Postfix) with ESMTP id 74E9E388EB4;
	Wed,  1 Mar 2006 13:10:46 -0600 (CST)
Date: Wed, 01 Mar 2006 13:10:46 -0600
From: Paul Schmehl <pauls@utdallas.edu>
To: Boris Samorodov <bsam@ipt.ru>
Message-ID: <C0D04BDAC59820A93DC4E43F@utd59514.utdallas.edu>
In-Reply-To: <84747890@srv.sem.ipt.ru>
References: <44050D77.2030503@j2d.lam.net.au>
	<BCA5F50D2461133FF65B3BD8@utd59514.utdallas.edu>
	<84747890@srv.sem.ipt.ru>
X-Mailer: Mulberry/3.1.6 (Linux/x86)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Cc: ports@FreeBSD.org
Subject: Re: FreeBSD Port: mpack-1.6
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Mar 2006 19:10:52 -0000

--On Wednesday, March 01, 2006 22:02:37 +0300 Boris Samorodov <bsam@ipt.ru> 
wrote:
>
>> I've looked through the source code, but I'm not sure where the
>> problem is. I only see one call to open the file.
>
> No. Lookup before mpack reads Makefile.
>
I see that, but I only see one call to open the file in the source.   I'll 
have to check to see what's calling that function.  Thanks.

> Can't say for sure why that patch exists, but deletting
> files/patch-unixpk_c should help. Cvs says "Yet another overflow
> check, better temp file name & misc cleanups". Assume this comment is
> for the whole commit.
>
I've already incorporated that patch in to the other one and deleted it, 
but that doesn't fix this bug.

Paul Schmehl (pauls@utdallas.edu)
Adjunct Information Security Officer
University of Texas at Dallas
AVIEN Founding Member
http://www.utdallas.edu/ir/security/