From nobody Tue Jun 10 15:57:11 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bGtj74TFtz5xr3V; Tue, 10 Jun 2025 15:57:31 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bGtj72Tz3z3bmd; Tue, 10 Jun 2025 15:57:31 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-604f5691bceso11443776a12.0; Tue, 10 Jun 2025 08:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749571044; x=1750175844; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DPvtk71TNBrQ3yfgqFyDaXRHAsffmwNJ8ev8Bv/LnIs=; b=R1VfQItyWzW4L0+b7+qSSKOsQLmJgQFjs1xwOyJEpV92yENo86txA/0MEjRZMkJjwW RIMe08oc5z+yOC31hcT7Kzf4qFChJoujkIC83ylhi+85f7GbNn/8y2QYAzYwuwIA+pqF N6MSFRiZ/TRb0dsetRENQgQh4hsQ9VqluoUPGDr5FOwNa3PRp+0o8B+0kbLEY0aQrJbl DkI0tyRh7gPnoQeimJD2FVFKnO5SxSRHaOWNYs3yuhHfDUDhEh/52lIn+fNWroS6hYH5 2eMIQQ6Kdl7L4QbuWQHXH8YgGoH2j/fp9uLh3lthdC73EzxtOFE1Y6Q3pNBF6Lj5ZJsF qJxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749571044; x=1750175844; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DPvtk71TNBrQ3yfgqFyDaXRHAsffmwNJ8ev8Bv/LnIs=; b=QR65Kegc13rOPCs3MKZRWzFcQB8/XRas0IuRGZS2Z3NdpL1SDDB77ovUXhCYURcRX7 mHQScawgC2/oVQWZG3qj66rTxNU8Jeggo6EkSon5M7D/2ZDhUV4dITvkjW4iNrgvlzXT +PKM7cfvyiErkCGxE0n9VDczLuIqw+pRt7YvIVWuSFsZKAvQ24edofAO5rNAe7v4EvJm k6XVtJXGzEhHH32w2ZQqagxl18Xi3uCqbYR0V7QPiKfkzVZfgAijfdfKRaCPqcS3m0tp K1fAZgogfnS2GfnH8D+r7C23If5VM0yQetwU7acKLZ48kxMkKMapAEZf/7drSlhxEIJu HkKA== X-Forwarded-Encrypted: i=1; AJvYcCUe+apnpMjj3kFVz91A0zuVXQXpymOr09BUS+s67ddFR9ImIpPf2tZb+21ydV/D6zKcKWJ7M7hWXaPptRh7nlg=@freebsd.org, AJvYcCWbXqCgPUQkB5CkL3Nav/MOJRIyP10L3HePxFs9VVnhPq0fkwgLTK+5+Ivf29O4VMdVdluCCRwVMEek1sI5wXc8wAv9sA==@freebsd.org, AJvYcCXO/6eYzC3kHvG+zkDsBW+8lo0911XF9K7ba6IiKZlSwSOPlcr0VMeO/w4Hz7K0ICOSq9g=@freebsd.org, AJvYcCXfxc26ZMde5KKshpnmVqfeaqwbtNMXDgqK0AxnlJ4Y4HvrG8YEhmcrdNsGWw90C4mtCux+nWMOEAN4puocmKTsHatiaR0=@freebsd.org X-Gm-Message-State: AOJu0YxNdXjwCBOAT0lj3MePjl81REVQYg4M6QtOLXn7hQjS5BNNHe0M vkgGRxYtqhqPcjSbwhFrhdPjh22A5JJEu/QKZlwegCcSORtya8J53GF3FcUUyua8FNpIC4mdYpT f6INhcLmcvsPWgqY9Y2mJcckzC4BD/ZBYsDq/uw== X-Gm-Gg: ASbGncvZrO3WfzrELoGHKn5rYu8RYOWqdUn3epRb3OYt1SYnAeUVF9VclTsPRdAOUES nCE5VA/nNXasInuyMIXi3qNgWC5rr3We+zjddBvg3c7kLdRzgWrKM8tA8QM6mtHLFqPxsQ+5bw0 ytWf57U1xTCKgtHTeKihixVygw8Or+jlOHg1lAGVHq15y/+19Bz4ImMoxuFFSS/msqe2f4JhImd Uc= X-Google-Smtp-Source: AGHT+IGSd2mDCmQId9W8+Q6yFC/x4WQu3ts6ikNfWzKB6G8i+bw02kYCdAC/d6mgDDEVgk1w196sf0pjWwPmPTxpDtE= X-Received: by 2002:a17:907:2d22:b0:ade:2e4b:50db with SMTP id a640c23a62f3a-ade7abfbdcfmr285238366b.10.1749571044156; Tue, 10 Jun 2025 08:57:24 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202506091053.559ArJ8k043104@gitrepo.freebsd.org> In-Reply-To: From: Rick Macklem Date: Tue, 10 Jun 2025 08:57:11 -0700 X-Gm-Features: AX0GCFvGk4UTjVPDEmr0Kxg739PuLuS4wF5NDqVvXWIW5fT7b4kEok3CkYlGip0 Message-ID: Subject: Re: git: 79d0f4474653 - main - rpcbind: Ensure krpc is present. To: Gleb Smirnoff Cc: Konstantin Belousov , =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4bGtj72Tz3z3bmd X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[] On Tue, Jun 10, 2025 at 8:41=E2=80=AFAM Gleb Smirnoff = wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > On Tue, Jun 10, 2025 at 12:11:18PM +0300, Konstantin Belousov wrote: > K> Apparently we already have the feature called 'warmstart', where rpcbi= nd > K> can be restarted and existing registrations are reloaded. So it is in > K> fact already solved, assuming admin is careful enough to use -w. > > Ok, then all that needs to be done is revert this: > > --- a/usr.sbin/rpcbind/rpcbind.c > +++ b/usr.sbin/rpcbind/rpcbind.c > @@ -159,10 +159,6 @@ main(int argc, char *argv[]) > > update_bound_sa(); > > - /* Ensure krpc is loaded */ > - if (modfind("krpc") < 0 && kldload("krpc") < 0) > - err(1, "krpc"); > - > /* Check that another rpcbind isn't already running. */ > if ((rpcbindlockfd =3D open(RPCBINDDLOCK, O_RDONLY|O_CREAT, 0444)= ) < 0) > err(1, "%s", RPCBINDDLOCK); > > Without these lines, rpcbind will log: > > Jun 10 08:34:23 bobrik rpcbind[885]: netlink: could not create service > > And continue with /var/run/rpcbind.sock set up and ready to service > requests from applications. > > We can add an extra message for verbosity: > > @@ -223,7 +219,10 @@ main(int argc, char *argv[]) > } > endnetconfig(nc_handle); > > - init_transport(&netlink_nconf); > + if (init_transport(&netlink_nconf) !=3D 0) { > + syslog(LOG_ERR, "krpc(4) module missing? " > + "Continuing without netlink/krpc transport"); > + } > > /* > * Allocate pipe fd to wake main thread from signal handler in no= n-racy > > I really don't have a strong opinion on what would be right here. I have= no > idea on how wide is the use of rpcbind w/o NFS. Kostik, Rick and Dag-Erl= ing, > may you together come to agreement on what is right here? I don't have a strong opinion on it either, since most kernel configs include NFS options, so the krpc is there anyhow. rick > > -- > Gleb Smirnoff