From owner-cvs-all@FreeBSD.ORG  Sun May 28 20:21:26 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9D2E416CA20;
	Sun, 28 May 2006 20:21:11 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1645943D46;
	Sun, 28 May 2006 20:21:10 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k4SKL3Il061125;
	Sun, 28 May 2006 14:21:08 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <447A062F.90704@samsco.org>
Date: Sun, 28 May 2006 14:21:03 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.7) Gecko/20050416
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Craig Rodrigues <rodrigc@FreeBSD.org>
References: <200605282009.k4SK9Ius088541@repoman.freebsd.org>
In-Reply-To: <200605282009.k4SK9Ius088541@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/fs/nullfs null_vfsops.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 May 2006 20:21:37 -0000

Craig Rodrigues wrote:

> rodrigc     2006-05-28 20:09:18 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/fs/nullfs        null_vfsops.c 
>   Log:
>   Modify MNT_UPDATE behavior for nullfs so that it does not
>   return EOPNOTSUPP if an "export" parameter was passed in.
>   This should allow nullfs mounts to be NFS exported.
>   
>   PR:             kern/87906
>   MFC after:      1 week
>   
>   Revision  Changes    Path
>   1.78      +7 -2      src/sys/fs/nullfs/null_vfsops.c

No, it won't.  The null_checkexp routine is wrong.  It should be
removed so that the default stdcheckexp routine will be called.
Why?  Because what null_checkexp is doing right now is passing
the call down to the lower filesystem.  If that filesystem isn't
also exported, then the call will fail.  When you export nullfs,
you are exporting the nullfs mountpoint, not the lower mountpoint.
Thus, there is no need to play the mountpoint pivot games with this
call.

Scott