From owner-freebsd-gnome@FreeBSD.ORG Fri Apr 11 15:55:01 2008 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA6B5106564A; Fri, 11 Apr 2008 15:55:01 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id 3976D8FC1D; Fri, 11 Apr 2008 15:55:01 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.2/8.14.2) with ESMTP id m3BFtW4U061398; Fri, 11 Apr 2008 11:55:32 -0400 (EDT) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: cokane@freebsd.org In-Reply-To: <47FF722B.109@FreeBSD.org> References: <47FD09AC.2020907@FreeBSD.org> <1207776230.61729.28.camel@shumai.marcuscom.com> <47FD34E8.2000005@FreeBSD.org> <1207872846.87478.38.camel@shumai.marcuscom.com> <47FF66E3.8000304@FreeBSD.org> <47FF722B.109@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-LWc1mjdYf94XrHginZgN" Organization: MarcusCom, Inc. Date: Fri, 11 Apr 2008 11:54:57 -0400 Message-Id: <1207929297.55415.13.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.4 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on creme-brulee.marcuscom.com Cc: gnome@freebsd.org Subject: Re: Seahorse issues X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Apr 2008 15:55:01 -0000 --=-LWc1mjdYf94XrHginZgN Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2008-04-11 at 10:14 -0400, Coleman Kane wrote: > I removed your earleir patch, which has the side effect of causing=20 > gnome_keyring_memory_try_alloc(size) to act in a manner that violates=20 > its documentation, as well as causing the above bug. I then added the=20 > three patches to security/seahorse which I posted into=20 > http://bugzilla.gnome.org/show_bug.cgi?id=3D527193 today: > * http://bugzilla.gnome.org/attachment.cgi?id=3D109055 > * http://bugzilla.gnome.org/attachment.cgi?id=3D109056 > * http://bugzilla.gnome.org/attachment.cgi?id=3D109057 >=20 > These three alter the behavior of Seahorse in the manner I described=20 > above, and don't touch gnome-keyring. For all purposes, I *think*=20 > gnome-keyring is acting properly here. The consumer of gnome-keyring=20 You're right. I was hoping to hack g-k in such a way to avoid having to fix other broken consumers in the future. Of course, my approach was very wrong. > (seahorse) should first be testing if the features that it wants to use=20 > are actually provided by the library before it blindingly attempts to=20 > use them. This is, IMHO, why gnome-keyring provides the *_try(...)=20 > versions of its securemem alloc functions. Fixing seahorse is the right thing to do. The bug has been moved into gnome-keyring's court, so you way want to get them to move it back. >=20 > Additionally, you'll get a seahorse g_warning about unavailable secure=20 > memory now too. Thanks for your work here. Feel free to commit these patches to our seahorse port. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-LWc1mjdYf94XrHginZgN Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEABECAAYFAkf/ic0ACgkQb2iPiv4Uz4c1nQCbB1p6k8NpSs1MlhVQbIYvkwZZ BUcAn2q0nTqZWAsF3pPtiyJ880st++BR =8aPB -----END PGP SIGNATURE----- --=-LWc1mjdYf94XrHginZgN--