From owner-freebsd-current@FreeBSD.ORG  Sat Jul 17 21:03:35 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C76B9106566B;
	Sat, 17 Jul 2010 21:03:35 +0000 (UTC)
	(envelope-from andreast-list@fgznet.ch)
Received: from smtp.fgznet.ch (mail.fgznet.ch [81.92.96.47])
	by mx1.freebsd.org (Postfix) with ESMTP id 4BCD88FC08;
	Sat, 17 Jul 2010 21:03:34 +0000 (UTC)
Received: from deuterium.andreas.nets (dhclient-91-190-8-131.flashcable.ch
	[91.190.8.131])
	by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id
	o6HL3WQE055820; Sat, 17 Jul 2010 23:03:32 +0200 (CEST)
	(envelope-from andreast-list@fgznet.ch)
Message-ID: <4C421AA4.3050304@fgznet.ch>
Date: Sat, 17 Jul 2010 23:03:32 +0200
From: Andreas Tobler <andreast-list@fgznet.ch>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
	rv:1.9.2.4) Gecko/20100608 Lightning/1.0b2 Thunderbird/3.1
MIME-Version: 1.0
To: Edward Tomasz Napierala <trasz@freebsd.org>,
	freebsd-current <freebsd-current@freebsd.org>
References: <201007171545.o6HFjKex070603@svn.freebsd.org>
In-Reply-To: <201007171545.o6HFjKex070603@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.64 on 81.92.96.47
Cc: 
Subject: Re: svn commit: r210194 - head/sys/fs/unionfs
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Jul 2010 21:03:35 -0000

On 17.07.10 17:45, Edward Tomasz Napierala wrote:
> Author: trasz
> Date: Sat Jul 17 15:45:20 2010
> New Revision: 210194
> URL: http://svn.freebsd.org/changeset/base/210194
>
> Log:
>    Remove updating process count by unionfs.  It serves no purpose, unionfs just
>    needs root credentials for a moment.
>
> Modified:
>    head/sys/fs/unionfs/union_subr.c
>
> Modified: head/sys/fs/unionfs/union_subr.c
> ==============================================================================
> --- head/sys/fs/unionfs/union_subr.c	Sat Jul 17 13:34:01 2010	(r210193)
> +++ head/sys/fs/unionfs/union_subr.c	Sat Jul 17 15:45:20 2010	(r210194)
> @@ -50,7 +50,6 @@
>   #include<sys/fcntl.h>
>   #include<sys/filedesc.h>
>   #include<sys/stat.h>
> -#include<sys/resourcevar.h>
>
>   #include<security/mac/mac_framework.h>
>
> @@ -775,7 +774,6 @@ unionfs_mkshadowdir(struct unionfs_mount
>   	/* Authority change to root */
>   	rootinfo = uifind((uid_t)0);
>   	cred = crdup(cnp->cn_cred);
> -	chgproccnt(cred->cr_ruidinfo, 1, 0);
>   	change_euid(cred, rootinfo);
>   	change_ruid(cred, rootinfo);
>   	change_svuid(cred, (uid_t)0);
> @@ -825,7 +823,6 @@ unionfs_mkshadowdir_free_out:
>
>   unionfs_mkshadowdir_abort:
>   	cnp->cn_cred = credbk;
> -	chgproccnt(cred->cr_ruidinfo, -1, 0);
>   	crfree(cred);
>
>   	return (error);
> _______________________________________________
> svn-src-head@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"
>
>
cc1: warnings being treated as errors
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c: 
In function 'unionfs_mkshadowdir':
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c:775: 
warning: implicit declaration of function 'uifind'
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c:775: 
warning: nested extern declaration of 'uifind'
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c:775: 
warning: assignment makes pointer from integer without a cast
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c:780: 
warning: implicit declaration of function 'uifree'
/export/devel/fbsd/head/src/sys/modules/unionfs/../../fs/unionfs/union_subr.c:780: 
warning: nested extern declaration of 'uifree'

Hm, I'd like to include this one again:

[tc:fbsd/head/src] andreast% svn diff sys/fs/unionfs/union_subr.c
Index: sys/fs/unionfs/union_subr.c
===================================================================
--- sys/fs/unionfs/union_subr.c	(revision 210200)
+++ sys/fs/unionfs/union_subr.c	(working copy)
@@ -50,6 +50,7 @@
  #include <sys/fcntl.h>
  #include <sys/filedesc.h>
  #include <sys/stat.h>
+#include <sys/resourcevar.h>

  #include <security/mac/mac_framework.h>


Gruss,
Andreas