From owner-svn-src-all@freebsd.org Sun Nov 3 02:18:45 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D011A1A18AB; Sun, 3 Nov 2019 02:18:45 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 475KNj592fz4Vjs; Sun, 3 Nov 2019 02:18:45 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 94B154D9E; Sun, 3 Nov 2019 02:18:45 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id xA32Ijrp081665; Sun, 3 Nov 2019 02:18:45 GMT (envelope-from bdragon@FreeBSD.org) Received: (from bdragon@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id xA32IjPa081664; Sun, 3 Nov 2019 02:18:45 GMT (envelope-from bdragon@FreeBSD.org) Message-Id: <201911030218.xA32IjPa081664@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: bdragon set sender to bdragon@FreeBSD.org using -f From: Brandon Bergren Date: Sun, 3 Nov 2019 02:18:45 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r354272 - head/sys/powerpc/powerpc X-SVN-Group: head X-SVN-Commit-Author: bdragon X-SVN-Commit-Paths: head/sys/powerpc/powerpc X-SVN-Commit-Revision: 354272 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Nov 2019 02:18:45 -0000 Author: bdragon Date: Sun Nov 3 02:18:45 2019 New Revision: 354272 URL: https://svnweb.freebsd.org/changeset/base/354272 Log: powerpc: Add display of raw instruction values to x/I in ddb. The "alternate format" character 'I' previously had the same behavior as the "display as an instruction" character 'i'. With this change, it will now prefix each disassembled instruction with the raw hex value. As PowerPC instructions are always 32 bits and always aligned, and there are no alternate modes that would affect instruction decoding or display, this seemed to me to be the obvious interpretation of "alternate format". Approved by: jhibbits (mentor) Differential Revision: https://reviews.freebsd.org/D22223 Modified: head/sys/powerpc/powerpc/db_disasm.c Modified: head/sys/powerpc/powerpc/db_disasm.c ============================================================================== --- head/sys/powerpc/powerpc/db_disasm.c Sun Nov 3 02:17:35 2019 (r354271) +++ head/sys/powerpc/powerpc/db_disasm.c Sun Nov 3 02:18:45 2019 (r354272) @@ -1073,6 +1073,8 @@ db_disasm(db_addr_t loc, bool extended) int class; instr_t opcode; opcode = *(instr_t *)(loc); + if (extended) + db_printf("|%08x| ", opcode); class = opcode >> 26; (opcodes_base[class])(opcode, loc);