From owner-freebsd-stable@FreeBSD.ORG  Wed Aug 29 21:14:01 2012
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B11BA106568E;
	Wed, 29 Aug 2012 21:14:01 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 896D08FC29;
	Wed, 29 Aug 2012 21:14:00 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA10796;
	Thu, 30 Aug 2012 00:13:36 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1T6pZw-000Pde-9P; Thu, 30 Aug 2012 00:13:36 +0300
Message-ID: <503E85FE.4050300@FreeBSD.org>
Date: Thu, 30 Aug 2012 00:13:34 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:14.0) Gecko/20120728 Thunderbird/14.0
MIME-Version: 1.0
To: Anton Yuzhanionov <ayuzhaninov@openstat.ru>
References: <503DE2AB.6030702@citrin.ru> <201208290825.44198.jhb@freebsd.org>
	<503E6E59.2000600@openstat.ru>
In-Reply-To: <503E6E59.2000600@openstat.ru>
X-Enigmail-Version: 1.4.3
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-stable@FreeBSD.org, John Baldwin <jhb@FreeBSD.org>
Subject: Re: Problem with IPMI KCS driver
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Aug 2012 21:14:01 -0000

on 29/08/2012 22:32 Anton Yuzhanionov said the following:
> On 29.08.2012 16:25, John Baldwin wrote:
>> Hmm.  Can you try this:
>>
>> Index: kern/kern_clock.c
>> ===================================================================
>> --- kern/kern_clock.c    (revision 239819)
>> +++ kern/kern_clock.c    (working copy)
>> @@ -382,7 +382,7 @@
>>   int    stathz;
>>   int    profhz;
>>   int    profprocs;
>> -int    ticks;
>> +volatile int    ticks;
>>   int    psratio;
>>
> 
> With this patch if_cdce.c can't be compiled:
> 
> /usr/src/sys/modules/usb/cdce/../../../dev/usb/net/if_cdce.c: In function
> 'cdce_attach':
> /usr/src/sys/modules/usb/cdce/../../../dev/usb/net/if_cdce.c:616: warning:
> passing argument 2 of 'memcpy' discards qualifiers from pointer target type
> *** Error code 1
> 
> memcpy(&sc->sc_ue.ue_eaddr[1], &ticks, sizeof(uint32_t));
> 
> As I understand, memcpy() don't accept pointers to volatile objects.
> May be some other source can be used for generated MAC address.

int x = ticks;
memcpy(..., &x, ...);
should work

> I have installed patched kernel (without cdce) and need some time to check if
> the problem with IPMI KCS is reproduced.
> 


-- 
Andriy Gapon