Date: Tue, 29 Jul 2014 10:51:57 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Adrian Chadd <adrian@freebsd.org> Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: [rfc] where to put cpuid_t ? Message-ID: <41D207A0-D82F-456E-B0A4-9CA9520D4F77@FreeBSD.org> In-Reply-To: <CAJ-VmokOpA8nFashcTpmU0j8Dyw_LX-VvVudcppuGyGV97PRbA@mail.gmail.com> References: <CAJ-VmokOpA8nFashcTpmU0j8Dyw_LX-VvVudcppuGyGV97PRbA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 24, 2014, at 12:03 AM, Adrian Chadd <adrian@freebsd.org> wrote: > Hi! > > I've been chipping away at a cpuid_t in a local branch for a while and > I think I have the very basics working well enough. > > However, the most annoying thing that's crept up is the most bikeshed > topic of them all - where should it live. > > I'd like to avoid having to include sys/pcpu.h or sys/_cpuset.h just > for the id type - it seems a bit overkill. > > So - suggestions? Otherwise I'm going to leave it in sys/pcpu.h and > just polluate appropriately. > > I'd like to try and get cpuid_t and a handful of KBI-changing things > into -HEAD before 11 is branched so we at least have a hope of trying > to support > 128 CPUs out of the box in the immediate future and > 253 > CPUs in the later future. __cpuid_t should be in <sys/_types.h> and cpuid_t should be in <sys/types.h>. This is how the old cpumask_t worked (though it allowed __cpumask_t to be MD whereas I think you can probably make __cpuid_t MI). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41D207A0-D82F-456E-B0A4-9CA9520D4F77>