From owner-freebsd-current  Wed May 12 10:51:23 1999
Delivered-To: freebsd-current@freebsd.org
Received: from bubba.whistle.com (s205m7.whistle.com [207.76.205.7])
	by hub.freebsd.org (Postfix) with ESMTP id 57F7314EA8
	for <freebsd-current@FreeBSD.ORG>; Wed, 12 May 1999 10:51:21 -0700 (PDT)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.2/8.9.2) id KAA61736;
	Wed, 12 May 1999 10:50:42 -0700 (PDT)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <199905121750.KAA61736@bubba.whistle.com>
Subject: Re: mbuf starvation
In-Reply-To: <19990512172544.A440@enst.fr> from Pierre Beyssac at "May 12, 99 05:25:44 pm"
To: beyssac@enst.fr (Pierre Beyssac)
Date: Wed, 12 May 1999 10:50:42 -0700 (PDT)
Cc: freebsd-current@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL38 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Pierre Beyssac writes:
>  			if (resid >= MINCLSIZE) {
>  				MCLGET(m, M_WAIT);
> +				if (m == 0) {
> +				    error = ENOBUFS;
> +				    goto release;
> +				}
>  				if ((m->m_flags & M_EXT) == 0)
>  					goto nopages;
>  				mlen = MCLBYTES;

I think this part of the patch is useless. MCLGET() does not set
m to NULL when it fails, it simply doesn't set the M_EXT flag.
...unless things have changed recently.

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message