From owner-svn-src-all@freebsd.org Mon Aug 26 22:00:41 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 714CBE63DB; Mon, 26 Aug 2019 22:00:41 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46HQtK2P3sz3yQ1; Mon, 26 Aug 2019 22:00:41 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f46.google.com with SMTP id l7so41296588ioj.6; Mon, 26 Aug 2019 15:00:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=3rLu+6wFnU1khWQofdzWu+RcbeDQ9a1GxxQMonNZUD4=; b=j2R26M7cYrFBjIYKrDqBItY47elQHiBHEHOHGiArfxU5UnzYyFPVi59ylmSY2gj3BY ZNaxhkG2OsXOtfNZBi/2R8XaitWc59ArgxgXV+OHO0BcQLYD+wNqroYuWQbMelvizFnM bIbpI3uSZciWrMacMpqKLTEsRH9KjiPPLLRQ6atKwILbXHJVU+NXdvYVdFgrqmuHilKt ZaM7jK+5CrI+i3rQKs/m00LYVE4UVl6J9BR8z1aXgM1K39SySe2hxB9Si+4OImvLlTwC pm2uA+hfTVsBJvEsOSnOoh21EDKDBzJGcKK9gnQ2FtxFoK/oYebytsrkoSOVmbKbkVhk 0Sqg== X-Gm-Message-State: APjAAAUwdKw/P1dD3oT9Jq5GPdaPD2l0JvZ/DOwfhLAlJD86isLej0Dj SYHpTeBpvGh7dLPhjeP7k0Kzi/mW X-Google-Smtp-Source: APXvYqwgdxb/46ZZaA8bd2FC9YqX1HzebMekZJeG8rOEjpNEJVH82IksByr6l+5R5r3qJq9xBpX6AQ== X-Received: by 2002:a02:ba99:: with SMTP id g25mr20436076jao.20.1566856840030; Mon, 26 Aug 2019 15:00:40 -0700 (PDT) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com. [209.85.166.53]) by smtp.gmail.com with ESMTPSA id d6sm17432165iod.17.2019.08.26.15.00.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2019 15:00:39 -0700 (PDT) Received: by mail-io1-f53.google.com with SMTP id p12so41304343iog.5; Mon, 26 Aug 2019 15:00:39 -0700 (PDT) X-Received: by 2002:a5d:8599:: with SMTP id f25mr26946955ioj.265.1566856839560; Mon, 26 Aug 2019 15:00:39 -0700 (PDT) MIME-Version: 1.0 References: <201908261727.x7QHRbsc020978@repo.freebsd.org> In-Reply-To: <201908261727.x7QHRbsc020978@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Mon, 26 Aug 2019 15:00:28 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351514 - head/sys/dev/pci To: Alexander Motin Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46HQtK2P3sz3yQ1 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Aug 2019 22:00:41 -0000 Hi Alexander, On Mon, Aug 26, 2019 at 10:27 AM Alexander Motin wrote: > > Author: mav > Date: Mon Aug 26 17:27:36 2019 > New Revision: 351514 > ... > - device_printf(dev, > - "HotPlug Command Timed Out - forcing detach\n"); > - sc->flags &= ~(PCIB_HOTPLUG_CMD_PENDING | PCIB_DETACH_PENDING); > - sc->flags |= PCIB_DETACHING; > - pcib_pcie_hotplug_update(sc, 0, 0, true); > + device_printf(dev, "HotPlug Command Timed Out\n"); > + sc->flags &= ~PCIB_HOTPLUG_CMD_PENDING; If this case is expected (and it seems like it is, at least in relatively common hardware), and the kernel isn't taking an action based on it anymore (formerly, it would then cause detach), is there any reason to print a message at all? What information should a user glean from the message, or what action should be taken? It seems like Nothing and None, respectively. So perhaps it is better to not print anything in this case? Or maybe mask it behind bootverbose. Best, Conrad