From owner-cvs-sys Sat Jul 13 03:31:56 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA01401 for cvs-sys-outgoing; Sat, 13 Jul 1996 03:31:56 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id DAA01387; Sat, 13 Jul 1996 03:31:23 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id UAA20129; Sat, 13 Jul 1996 20:19:55 +1000 Date: Sat, 13 Jul 1996 20:19:55 +1000 From: Bruce Evans Message-Id: <199607131019.UAA20129@godzilla.zeta.org.au> To: bde@freefall.freebsd.org, julian@ref.tfs.com Subject: Re: cvs commit: src/sys/i386/boot/biosboot asm.h start.S Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> Modified: sys/i386/boot/biosboot asm.h start.S >> Log: >> Moved the definition of DEBUGMSG() from asm.h to start.S. This macro >> is only appropriate to use in the special environment of start.S (real >> mode plus some conventions about not saving registers), and asm.h is >> supposed to be for generic macros. > This is a bad move.. > DEBUGMSG is useful right up through quite a bit of boot2.S > I used it ito find how far I was getting into boot2.S > which is the reason that it was moved to asm.h > can you please put it back there!? I thought boot2.S was "finished". I want to merge it into start.S anyway. The text size of boot2.o (with standard options) is 112 bytes and there are 185 bytes to spare. I probably won't do this until we import a current version of gas to get proper support for 16-bit mode. Bruce