From owner-freebsd-stable Tue Jan 8 23:53:24 2002 Delivered-To: freebsd-stable@freebsd.org Received: from smtp.shikoku.ne.jp (smtp.shikoku.ne.jp [210.143.160.28]) by hub.freebsd.org (Postfix) with SMTP id DD21437B405 for ; Tue, 8 Jan 2002 23:53:15 -0800 (PST) Received: (qmail 31325 invoked from network); 9 Jan 2002 07:44:04 -0000 Received: from unknown (HELO mebius.private) (210.143.180.119) by smtp.shikoku.ne.jp with SMTP; 9 Jan 2002 07:44:04 -0000 Date: Wed, 09 Jan 2002 16:50:28 +0900 (JST) Message-Id: <20020109.165028.74743563.nin@smtp.shikoku.ne.jp> To: dillon@apollo.backplane.com Cc: steve@Watt.COM, stable@FreeBSD.ORG, re@FreeBSD.ORG Subject: Re: VXLOCK interlock avoided messages From: NINOMIYA Hideyuki In-Reply-To: <200201082122.g08LMTp61466@apollo.backplane.com> References: <200201082110.g08LAqJ97852@wattres.Watt.COM> <200201082122.g08LMTp61466@apollo.backplane.com> X-cite-me: nin X-PGP-Fingerprint: 6C59 EC08 5B23 6490 44D0 7CD3 DA40 219F 7114 8553 X-PGP-Public-Key: http://user.shikoku.ne.jp/~nin/pgp/public-key.txt X-URI: http://user.shikoku.ne.jp/~nin/index.html X-URI: http://home.Jp.FreeBSD.org/~nin/index.html X-Mailer: Mew version 3.0.52 on Emacs 21.1 / Mule 5.0 =?iso-2022-jp?B?KBskQjgtTFobKEIp?= X-Face: }ft&~i*0<;p9PLxI*G[:X *Bzq[.pq8DgHW)Vf6t{KT[Wjh(.Q_%0(]U,u=BDy5S Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, Matthew Dillon wrote: Date: Tue, 8 Jan 2002 13:22:29 -0800 (PST) Subject: Re: VXLOCK interlock avoided messages Message-Id: <200201082122.g08LMTp61466@apollo.backplane.com> > We changed this warning into a log() message, but perhaps we should > simply remove it entirely. > It's a bogus warning. If the RE's agree I would like to simply remove > the associated log() calls. I thought that the following modification would be good. Index: vfs_subr.c =================================================================== RCS file: /ext/freebsd_cvs/src/sys/kern/vfs_subr.c,v retrieving revision 1.249.2.22 diff -u -r1.249.2.22 vfs_subr.c --- vfs_subr.c 25 Dec 2001 01:27:55 -0000 1.249.2.22 +++ vfs_subr.c 9 Jan 2002 02:29:24 -0000 @@ -1491,7 +1491,9 @@ } if (vp->v_flag & VXLOCK) { if (vp->v_vxproc == curproc) { +#ifdef DEBUG_LOCKS log(LOG_INFO, "VXLOCK interlock avoided\n"); +#endif } else { vp->v_flag |= VXWANT; simple_unlock(&vp->v_interlock); Index: vfs_vnops.c =================================================================== RCS file: /ext/freebsd_cvs/src/sys/kern/vfs_vnops.c,v retrieving revision 1.87.2.10 diff -u -r1.87.2.10 vfs_vnops.c --- vfs_vnops.c 25 Dec 2001 01:44:44 -0000 1.87.2.10 +++ vfs_vnops.c 9 Jan 2002 02:29:27 -0000 @@ -661,9 +661,9 @@ tsleep((caddr_t)vp, PINOD, "vn_lock", 0); error = ENOENT; } else { +#ifdef DEBUG_LOCKS if (vp->v_vxproc != NULL) log(LOG_INFO, "VXLOCK interlock avoided in vn_lock\n"); -#ifdef DEBUG_LOCKS vp->filename = filename; vp->line = line; #endif =================================================================== # This message may be beneficial for debug ... :-) How do all of you think? ---- *************************************************************** * This message is a thing by output of automatic translation. * * Therefore it will be for there to be a lot of funny parts. * * Please approve it. * *************************************************************** NINOMIYA(family name) Hideyuki(fast name) @ ehime japan mailto:nin@shikoku.ne.jp mailto:nin@Jp.FreeBSD.org PGP-Fingerprint:6C59 EC08 5B23 6490 44D0 7CD3 DA40 219F 7114 8553 PGP-Public-Key: http://user.shikoku.ne.jp/~nin/pgp/public-key.txt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message