From owner-freebsd-scsi@FreeBSD.ORG  Fri Jul 29 19:42:08 2011
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6FC4A106564A;
	Fri, 29 Jul 2011 19:42:08 +0000 (UTC)
	(envelope-from aboyer@averesystems.com)
Received: from zimbra.averesystems.com
	(75-149-8-245-Pennsylvania.hfc.comcastbusiness.net [75.149.8.245])
	by mx1.freebsd.org (Postfix) with ESMTP id 43F0F8FC0A;
	Fri, 29 Jul 2011 19:42:08 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by zimbra.averesystems.com (Postfix) with ESMTP id 9BFDE446001;
	Fri, 29 Jul 2011 15:26:51 -0400 (EDT)
X-Virus-Scanned: amavisd-new at averesystems.com
Received: from zimbra.averesystems.com ([127.0.0.1])
	by localhost (zimbra.averesystems.com [127.0.0.1]) (amavisd-new,
	port 10024)
	with ESMTP id 2MbrMIVkwxb3; Fri, 29 Jul 2011 15:26:49 -0400 (EDT)
Received: from riven.arriad.com (fw.arriad.com [10.0.0.16])
	by zimbra.averesystems.com (Postfix) with ESMTPSA id B96CB446004;
	Fri, 29 Jul 2011 15:26:49 -0400 (EDT)
From: Andrew Boyer <aboyer@averesystems.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Date: Fri, 29 Jul 2011 15:24:03 -0400
Message-Id: <8B3E8C5D-C8BF-4AB7-AA1E-54086C6DC818@averesystems.com>
To: bz@FreeBSD.org,
 John Baldwin <jhb@FreeBSD.org>
Mime-Version: 1.0 (Apple Message framework v1084)
X-Mailer: Apple Mail (2.1084)
Cc: freebsd-scsi@freebsd.org
Subject: Buglet in r222899 (mfiutil show drives)
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jul 2011 19:42:08 -0000

The error variable is returned uninitialized if no error occurs.  I =
noticed because 'mfiutil -de show drives' started returning 1 for no =
apparent reason when I synced up to stable/8.

I looked through the rest of mfiutil and didn't see any more cases like =
this one.

-Andrew

Index: usr.sbin/mfiutil/mfi_show.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- usr.sbin/mfiutil/mfi_show.c	(revision 224494)
+++ usr.sbin/mfiutil/mfi_show.c	(working copy)
@@ -470,7 +470,7 @@
 	struct mfi_pd_list *list;
 	struct mfi_pd_info info;
 	u_int i, len, state_len;
-	int error, fd;
+	int error =3D 0, fd;
=20
 	if (ac !=3D 1) {
 		warnx("show drives: extra arguments");

--------------------------------------------------
Andrew Boyer	aboyer@averesystems.com