From owner-freebsd-current@FreeBSD.ORG Fri Dec 24 18:28:15 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C2BF16A4CE for ; Fri, 24 Dec 2004 18:28:15 +0000 (GMT) Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.200]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8927E43D3F for ; Fri, 24 Dec 2004 18:28:14 +0000 (GMT) (envelope-from avleeuwen@gmail.com) Received: by rproxy.gmail.com with SMTP id 40so106349rnz for ; Fri, 24 Dec 2004 10:28:11 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=PeJJpWAOMumEEWz7umpNY8g1Di+wvC7ket9Swjblr986+RUG0Izgsi6s9B8+3eCIWkX5ngaD3LW+mtEl47Mq7LGU24I4vmm23ses8N/W4FxRO7fA2vtYW3TajxwgW9UwGHEYUseRujsfac3ceiT03vk1lpd7n9vjqZwy1wLZRq8= Received: by 10.38.26.40 with SMTP id 40mr305655rnz; Fri, 24 Dec 2004 10:28:11 -0800 (PST) Received: by 10.38.206.10 with HTTP; Fri, 24 Dec 2004 10:28:11 -0800 (PST) Message-ID: Date: Fri, 24 Dec 2004 19:28:11 +0100 From: Arjan Van Leeuwen To: Darren Reed In-Reply-To: <200412240918.iBO9IRlo028138@cairo.anu.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <200412240918.iBO9IRlo028138@cairo.anu.edu.au> cc: current@freebsd.org Subject: Re: IPFilter patched for SMP X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Arjan Van Leeuwen List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Dec 2004 18:28:15 -0000 Hi Darren, On Fri, 24 Dec 2004 20:18:27 +1100 (EST), Darren Reed wrote: > > I've just committed some changes to IPFilter in FreeBSD-current that > remove the "needs giant" flag and enables fine grained locking. > > I'd really like to hear back from anyone who can stress test this out > on a multi-cpu machine. The locking used is the same as for Solaris > and IRIX, so I'm relatively confident it shouldn't cause any deadlocks > but I'd still like to see it tested. Thanks, that's a nice christmas present! I'm getting some build errors though: cc -O2 -pipe -DUSE_INET6 -I/usr/src/sys/modules/ipfilter/../../contrib/ipfilter -DIPFILTER=1-DIPFILTER_LKM -DIPFILTER_LOG -DPFIL_HOOKS -D_KERNEL -DKLD_MODULE -nostdinc -I- -I/usr/src/sys/modules/ipfilter/../../contrib/ipfilter -include /usr/obj/usr/src/sys/VINCENT/opt_global.h -I. -I@ -I@/contrib/altq -I@/../include -finline-limit=8000 -fno-common -g -fno-omit-frame-pointer -I/usr/obj/usr/src/sys/VINCENT -mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -c /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c In file included from /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:109: /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.h:501:1: warning: "PFIL_HOOKS" redefined :6:1: warning: this is the location of the previous definition /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c: In function `fr_forgetifp': /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:922: error: `ipf_mutex'undeclared (first use in this function) /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:922: error: (Each undeclared identifier is reported only once /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:922: error: for each function it appears in.) /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c: In function `ipfr_fastroute': /usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:1779: error: `ipf_rw' undeclared (first use in this function) *** Error code 1 Stop in /usr/src/sys/modules/ipfilter. *** Error code 1 Stop in /usr/src/sys/modules. *** Error code 1 Stop in /usr/obj/usr/src/sys/VINCENT. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. Arjan > > Merry Christmas, > Darren > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >