From owner-freebsd-stable@FreeBSD.ORG  Thu Sep 30 13:06:52 2010
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 828941065674
	for <freebsd-stable@freebsd.org>; Thu, 30 Sep 2010 13:06:52 +0000 (UTC)
	(envelope-from jdc@koitsu.dyndns.org)
Received: from qmta15.emeryville.ca.mail.comcast.net
	(qmta15.emeryville.ca.mail.comcast.net [76.96.27.228])
	by mx1.freebsd.org (Postfix) with ESMTP id 6554C8FC08
	for <freebsd-stable@freebsd.org>; Thu, 30 Sep 2010 13:06:51 +0000 (UTC)
Received: from omta11.emeryville.ca.mail.comcast.net ([76.96.30.36])
	by qmta15.emeryville.ca.mail.comcast.net with comcast
	id Cztg1f0020mlR8UAF16rkj; Thu, 30 Sep 2010 13:06:51 +0000
Received: from koitsu.dyndns.org ([98.248.41.155])
	by omta11.emeryville.ca.mail.comcast.net with comcast
	id D16p1f00K3LrwQ28X16q62; Thu, 30 Sep 2010 13:06:50 +0000
Received: by icarus.home.lan (Postfix, from userid 1000)
	id 9391E9B418; Thu, 30 Sep 2010 06:06:49 -0700 (PDT)
Date: Thu, 30 Sep 2010 06:06:49 -0700
From: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: Paul Mather <paul@gromit.dlib.vt.edu>
Message-ID: <20100930130649.GA18206@icarus.home.lan>
References: <20100930065151.GA9634@icarus.home.lan>
	<20100930070333.GU87427@hoeg.nl>
	<20100930072819.GA10678@icarus.home.lan>
	<4CA43C91.5040000@FreeBSD.org>
	<20100930075616.GA11519@icarus.home.lan>
	<E04F963B-7AAF-4483-8B60-6BBA2AFCCD28@gromit.dlib.vt.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E04F963B-7AAF-4483-8B60-6BBA2AFCCD28@gromit.dlib.vt.edu>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Ed Schouten <ed@80386.nl>, freebsd-stable@FreeBSD.org,
	Alex Dupre <ale@FreeBSD.org>
Subject: Re: mysqld_safe holding open a pty/tty on FreeBSD (7.x and 8.x)
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Sep 2010 13:06:52 -0000

On Thu, Sep 30, 2010 at 08:53:07AM -0400, Paul Mather wrote:
> On Sep 30, 2010, at 3:56 AM, Jeremy Chadwick wrote:
> 
> > The diff is pretty obvious/simple (2 line change), so the other
> > databases/mysqlXX-server ports can be upgraded in the same manner.
> > 
> > --- files/mysql-server.sh.in.orig	2010-03-27 03:24:53.000000000 -0700
> > +++ files/mysql-server.sh.in	2010-09-30 00:45:38.000000000 -0700
> > @@ -35,8 +35,8 @@
> > mysql_user="mysql"
> > mysql_limits_args="-e -U ${mysql_user}"
> > pidfile="${mysql_dbdir}/`/bin/hostname`.pid"
> > -command="%%PREFIX%%/bin/mysqld_safe"
> > -command_args="--defaults-extra-file=${mysql_dbdir}/my.cnf --user=${mysql_user} --datadir=${mysql_dbdir} --pid-file=${pidfile} ${mysql_args} > /dev/null 2>&1 &"
> > +command="/usr/sbin/daemon"
> > +command_args="-c -f /usr/local/bin/mysqld_safe --defaults-extra-file=${mysql_dbdir}/my.cnf --user=${mysql_user} --datadir=${mysql_dbdir} --pid-file=${pidfile} ${mysql_args}"
> 
> Shouldn't this be "-c -f %%PREFIX%%/bin/mysqld_safe ..." rather than hard-coding /usr/local?

Yes.

-- 
| Jeremy Chadwick                                   jdc@parodius.com |
| Parodius Networking                       http://www.parodius.com/ |
| UNIX Systems Administrator                  Mountain View, CA, USA |
| Making life hard for others since 1977.              PGP: 4BD6C0CB |