From owner-freebsd-stable@FreeBSD.ORG Fri Sep 19 14:20:31 2008 Return-Path: Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E8514106570F; Fri, 19 Sep 2008 14:20:31 +0000 (UTC) (envelope-from olli@lurza.secnetix.de) Received: from lurza.secnetix.de (unknown [IPv6:2a01:170:102f::2]) by mx1.freebsd.org (Postfix) with ESMTP id 63D818FC0C; Fri, 19 Sep 2008 14:20:31 +0000 (UTC) (envelope-from olli@lurza.secnetix.de) Received: from lurza.secnetix.de (localhost [127.0.0.1]) by lurza.secnetix.de (8.14.3/8.14.3) with ESMTP id m8JEKTHI002636; Fri, 19 Sep 2008 16:20:29 +0200 (CEST) (envelope-from oliver.fromme@secnetix.de) Received: (from olli@localhost) by lurza.secnetix.de (8.14.3/8.14.3/Submit) id m8JEKTEf002635; Fri, 19 Sep 2008 16:20:29 +0200 (CEST) (envelope-from olli) Date: Fri, 19 Sep 2008 16:20:29 +0200 (CEST) Message-Id: <200809191420.m8JEKTEf002635@lurza.secnetix.de> From: Oliver Fromme To: freebsd-stable@FreeBSD.ORG, jhb@FreeBSD.ORG In-Reply-To: <200809171144.48424.jhb@freebsd.org> X-Newsgroups: list.freebsd-stable User-Agent: tin/1.8.3-20070201 ("Scotasay") (UNIX) (FreeBSD/6.4-PRERELEASE-20080904 (i386)) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.1.2 (lurza.secnetix.de [127.0.0.1]); Fri, 19 Sep 2008 16:20:30 +0200 (CEST) Cc: Subject: Re: ACPI "blacklist" question X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Sep 2008 14:20:32 -0000 John Baldwin wrote: > On Wednesday 17 September 2008 07:47:18 am Oliver Fromme wrote: > > I have recently updated a machine to 7-stable. > > ACPI doesn't seem to work correctly on this machine. > > With earlier versions of FreeBSD (including the latest > > RELENG_6), I got this line in dmesg: > > > > ACPI disabled by blacklist. Contact your BIOS vendor. > > > > And everything was fine. The box runs perfectly well > > with ACPI disabled. (I can't get a BIOS update because > > the mainboard is too old.) > > > > When I updated to RELENG_7 a few days ago, the above line > > did _not_ appear anymore, and the machine didn't proceed > > [...] > > This is a regression. Try this fix: > > Index: acpi_quirk.c > =================================================================== > --- acpi_quirk.c (revision 183112) > +++ acpi_quirk.c (working copy) > @@ -149,9 +149,9 @@ > if (ACPI_FAILURE(AcpiGetTableHeader(ACPI_SIG_FADT, 0, &fadt))) > bzero(&fadt, sizeof(fadt)); > if (ACPI_FAILURE(AcpiGetTableHeader(ACPI_SIG_DSDT, 0, &dsdt))) > - bzero(&fadt, sizeof(dsdt)); > + bzero(&dsdt, sizeof(dsdt)); > if (ACPI_FAILURE(AcpiGetTableHeader(ACPI_SIG_XSDT, 0, &xsdt))) > - bzero(&fadt, sizeof(xsdt)); > + bzero(&xsdt, sizeof(xsdt)); > > /* Then, override the quirks with any matched from table signatures. */ > for (entry = acpi_quirks_table; entry->match; entry++) { The patch fixes the problem. The blacklist message is now back again, and the machine boots without hints right out of the box. Thanks! Best regards Oliver -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.'