From owner-svn-ports-all@FreeBSD.ORG  Fri May 30 09:31:13 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A5778A50;
 Fri, 30 May 2014 09:31:13 +0000 (UTC)
Received: from mail-yk0-x231.google.com (mail-yk0-x231.google.com
 [IPv6:2607:f8b0:4002:c07::231])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3D99F2284;
 Fri, 30 May 2014 09:31:13 +0000 (UTC)
Received: by mail-yk0-f177.google.com with SMTP id 19so1272392ykq.22
 for <multiple recipients>; Fri, 30 May 2014 02:31:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=DP146UliG1kMO8LyFkm6yW4Eg5rcR+VFwzDvhkVHDAA=;
 b=Pv0xQm/QA6rVtjbVaTETfRTGf/6C5R1S2/oZn+GJUWiznCuMuc8tUxDmhauaUp+c4Y
 vlhY7Pu1NwWykGkJFuHL33fHbqyWnUlzqhRNiRd4ROEkGpLWkdtOCg3LWI+YPX2n9N6v
 n+z1TGBwNOhU5GuZxLVif8tKDvJQ/NRKNWSbXXF65lioalIh87i5MP1QqDuKfE3I2KWI
 XPRRocLpH8cOmPqo26Pd6Q1S1gnzTbQo9oMXWT4q0b4CrCpdwuXndjWGVv8r6HtqUmgw
 mdCSfSqaKvhxCag6aVsh74t0tcEsIFrnq6afZUYpaqzKI9ei0INyW8hv3ua5KJo2eOiQ
 VEpg==
MIME-Version: 1.0
X-Received: by 10.236.192.73 with SMTP id h49mr19432773yhn.6.1401442272299;
 Fri, 30 May 2014 02:31:12 -0700 (PDT)
Sender: antoine.brodin.freebsd@gmail.com
Received: by 10.170.50.80 with HTTP; Fri, 30 May 2014 02:31:12 -0700 (PDT)
In-Reply-To: <201405300923.s4U9N2SU054380@svn.freebsd.org>
References: <201405300923.s4U9N2SU054380@svn.freebsd.org>
Date: Fri, 30 May 2014 11:31:12 +0200
X-Google-Sender-Auth: wKshcNMMT5Mr1SMTwdoiiZhPsr8
Message-ID: <CAALwa8k-48YpPwA2qiMw+fwmdE4QJ=JHBkv=tSv2XUpWAPAFKA@mail.gmail.com>
Subject: Re: svn commit: r355806 - head/x11-themes/clearlooks-themes-extras
From: Antoine Brodin <antoine@FreeBSD.org>
To: John Marino <marino@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 May 2014 09:31:13 -0000

On Fri, May 30, 2014 at 11:23 AM, John Marino <marino@freebsd.org> wrote:
> Author: marino
> Date: Fri May 30 09:23:02 2014
> New Revision: 355806
> URL: http://svnweb.freebsd.org/changeset/ports/355806
> QAT: https://qat.redports.org/buildarchive/r355806/
>
> Log:
>   x11-themes/clearlooks-themes-extras: Stage support+
>
>   In addition to supporting stage, the unnecessarily custom extraction
>   target was replaced with NO_WRKSUBDIR.
>
> Modified:
>   head/x11-themes/clearlooks-themes-extras/Makefile

Hi,

This looks wrong:
- creates a directory outside of stagedir during install
- use of NO_WRKSUBDIR + cd ${WRKSRC} && ${FIND} . ... is usually harmfull

Cheers,

Antoine


>
> Modified: head/x11-themes/clearlooks-themes-extras/Makefile
> ==============================================================================
> --- head/x11-themes/clearlooks-themes-extras/Makefile   Fri May 30 09:21:44 2014        (r355805)
> +++ head/x11-themes/clearlooks-themes-extras/Makefile   Fri May 30 09:23:02 2014        (r355806)
> @@ -12,11 +12,11 @@ MAINTAINER= ports@FreeBSD.org
>  COMMENT=       Extras colour schemes for Clearlooks engine theme
>
>  NO_BUILD=      yes
> +NO_WRKSUBDIR=  yes
>  USE_GNOME=     gtk20
>
>  THEME_DIR=     ${PREFIX}/share/themes
>
> -NO_STAGE=      yes
>  .include <bsd.port.pre.mk>
>
>  .if exists(${LOCALBASE}/libdata/pkgconfig/gtk-engines-2.pc) || defined(WITH_GTKENGINE)
> @@ -25,14 +25,10 @@ RUN_DEPENDS=        ${LOCALBASE}/libdata/pkgcon
>  RUN_DEPENDS=   ${LOCALBASE}/lib/gtk-2.0/${GTK2_VERSION}/engines/libclearlooks.so:${PORTSDIR}/x11-themes/clearlooks
>  .endif
>
> -do-extract:
> -       @${MKDIR} ${WRKSRC}
> -       @(cd ${WRKSRC} && ${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} \
> -               ${DISTDIR}/${DISTFILES} ${EXTRACT_AFTER_ARGS})
> -
>  do-install:
>         @${MKDIR} ${THEME_DIR}
>         @cd ${WRKSRC} && ${FIND} . -print | \
> -               ${CPIO} -pdm -L -R ${SHAREOWN}:${SHAREGRP} ${THEME_DIR}
> +               ${CPIO} -pdm -L -R ${SHAREOWN}:${SHAREGRP} \
> +               ${STAGEDIR}${THEME_DIR}
>
>  .include <bsd.port.post.mk>
>