From owner-svn-src-all@FreeBSD.ORG Tue Apr 20 07:09:47 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 818B4106564A; Tue, 20 Apr 2010 07:09:47 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31]) by mx1.freebsd.org (Postfix) with ESMTP id 4477A8FC16; Tue, 20 Apr 2010 07:09:47 +0000 (UTC) Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1]) by mail.cs.rice.edu (Postfix) with ESMTP id B302F2C2B0E; Tue, 20 Apr 2010 02:09:46 -0500 (CDT) X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu Received: from mail.cs.rice.edu ([127.0.0.1]) by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cSM087aFbX97; Tue, 20 Apr 2010 02:09:39 -0500 (CDT) Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cs.rice.edu (Postfix) with ESMTP id 43D662C2ACE; Tue, 20 Apr 2010 02:09:38 -0500 (CDT) Message-ID: <4BCD5331.4030303@cs.rice.edu> Date: Tue, 20 Apr 2010 02:09:37 -0500 From: Alan Cox User-Agent: Thunderbird 2.0.0.24 (X11/20100327) MIME-Version: 1.0 To: kmacy@freebsd.org References: <201004031620.o33GKM0n037332@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alan Cox , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r206140 - head/sys/vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2010 07:09:47 -0000 K. Macy wrote: > How has the problem been addressed? I'm seeing periodic panics with > non-zero resident count with the page lock patch applied. It is > possible that I've inadvertently re-introduced an issue you've fixed. > > r196318 and r189783 come to mind. > > On Sat, Apr 3, 2010 at 9:20 AM, Alan Cox wrote: > >> Author: alc >> Date: Sat Apr 3 16:20:22 2010 >> New Revision: 206140 >> URL: http://svn.freebsd.org/changeset/base/206140 >> >> Log: >> Re-enable the call to pmap_release() by vmspace_dofree(). The accounting >> problem that is described in the comment has been addressed. >> >> Submitted by: kib >> Tested by: pho (a few months ago) >> MFC after: 6 weeks >> >> Modified: >> head/sys/vm/vm_map.c >> >> Modified: head/sys/vm/vm_map.c >> ============================================================================== >> --- head/sys/vm/vm_map.c Sat Apr 3 15:52:32 2010 (r206139) >> +++ head/sys/vm/vm_map.c Sat Apr 3 16:20:22 2010 (r206140) >> @@ -313,6 +313,7 @@ vm_init2(void) >> static inline void >> vmspace_dofree(struct vmspace *vm) >> { >> + >> CTR1(KTR_VM, "vmspace_free: %p", vm); >> >> /* >> @@ -329,12 +330,8 @@ vmspace_dofree(struct vmspace *vm) >> (void)vm_map_remove(&vm->vm_map, vm->vm_map.min_offset, >> vm->vm_map.max_offset); >> >> - /* >> - * XXX Comment out the pmap_release call for now. The >> - * vmspace_zone is marked as UMA_ZONE_NOFREE, and bugs cause >> - * pmap.resident_count to be != 0 on exit sometimes. >> - */ >> -/* pmap_release(vmspace_pmap(vm)); */ >> + pmap_release(vmspace_pmap(vm)); >> + vm->vm_map.pmap = NULL; >> uma_zfree(vmspace_zone, vm); >> } >> >> >>