From owner-freebsd-arch Wed Sep 11 0:18: 8 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE86C37B400; Wed, 11 Sep 2002 00:18:06 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD30F43E4A; Wed, 11 Sep 2002 00:18:05 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g8B7I3Uk024014; Wed, 11 Sep 2002 09:18:03 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Nate Lawson Cc: des@freebsd.org, arch@freebsd.org Subject: Re: PATCH: vnode->v_tag to const char * In-Reply-To: Your message of "Tue, 10 Sep 2002 16:38:09 PDT." Date: Wed, 11 Sep 2002 09:18:03 +0200 Message-ID: <24013.1031728683@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message , Nate Lawson wri tes: >I have built and tested a patch that changes v_tag and all users of >it. Since it should never be accessed other than for debugging, it is now >a const char *, set by the caller of getnewvnode(9). Background: The main motivations for this change is to make it hard(er) for code to abuse v_tag, since doing so is almost invariably a mistake and to remove the need to edit the vtagtype enum in everytime a filesystem is added. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message