Date: Tue, 03 Sep 2019 14:07:11 -0000 From: Rebecca Cran <rebecca@bluestop.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346039 - head/sys/conf Message-ID: <c8880833-5a0e-c05c-1b3c-c6b027fed42c@bluestop.org> In-Reply-To: <201904081825.x38IPEpV054311@repo.freebsd.org> References: <201904081825.x38IPEpV054311@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-04-08 12:25, Warner Losh wrote: > Author: imp > Date: Mon Apr 8 18:25:14 2019 > New Revision: 346039 > URL: https://svnweb.freebsd.org/changeset/base/346039 > > Log: > Style only change: Prefer $() to `` > > $() is more modern and also nests. Convert the mix of styles to using > only the former (although the latter was more common). It's the more > dominant style in other shell scripts these days as well. > > Differential Revision: https://reviews.freebsd.org/D19840 > > Modified: > head/sys/conf/newvers.sh > > Modified: head/sys/conf/newvers.sh I thought I saw an email a few weeks ago that suggested that the list of people who reviewed the patch should be copied into a "Reviewed by:" line, to avoid only having that information in Phabricator. Am I remembering correctly, or is just mentioning the Phab review considered sufficient? -- Rebecca Cran
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c8880833-5a0e-c05c-1b3c-c6b027fed42c>