From owner-svn-ports-all@FreeBSD.ORG  Fri May 30 09:43:18 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D6E4AC5;
 Fri, 30 May 2014 09:43:18 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id ABD372386;
 Fri, 30 May 2014 09:43:17 +0000 (UTC)
Received: from [192.168.0.21] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 35F00438EB;
 Fri, 30 May 2014 04:42:59 -0500 (CDT)
Message-ID: <53885290.20102@marino.st>
Date: Fri, 30 May 2014 11:42:40 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Antoine Brodin <antoine@FreeBSD.org>, 
 John Marino <marino@freebsd.org>
Subject: Re: svn commit: r355806 - head/x11-themes/clearlooks-themes-extras
References: <201405300923.s4U9N2SU054380@svn.freebsd.org>
 <CAALwa8k-48YpPwA2qiMw+fwmdE4QJ=JHBkv=tSv2XUpWAPAFKA@mail.gmail.com>
In-Reply-To: <CAALwa8k-48YpPwA2qiMw+fwmdE4QJ=JHBkv=tSv2XUpWAPAFKA@mail.gmail.com>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 May 2014 09:43:18 -0000

On 5/30/2014 11:31, Antoine Brodin wrote:
> On Fri, May 30, 2014 at 11:23 AM, John Marino <marino@freebsd.org> wrote:
>> Author: marino
>> Date: Fri May 30 09:23:02 2014
>> New Revision: 355806
>> URL: http://svnweb.freebsd.org/changeset/ports/355806
>> QAT: https://qat.redports.org/buildarchive/r355806/
>>
>> Log:
>>   x11-themes/clearlooks-themes-extras: Stage support+
>>
>>   In addition to supporting stage, the unnecessarily custom extraction
>>   target was replaced with NO_WRKSUBDIR.
>>
>> Modified:
>>   head/x11-themes/clearlooks-themes-extras/Makefile
> 
> Hi,
> 
> This looks wrong:
> - creates a directory outside of stagedir during install

I missed "@${MKDIR} ${THEME_DIR}" => "@${MKDIR} ${STAGEDIR}${THEME_DIR}"
unfortunately redports didn't complain


> - use of NO_WRKSUBDIR + cd ${WRKSRC} && ${FIND} . ... is usually harmfull

why?  I would have used COPYTREE or something myself but I don't see
anything immediately wrong with this.

John