From nobody Mon Jul 26 18:07:55 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CE9F412D6DFD for ; Mon, 26 Jul 2021 18:07:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GYSZg55Vhz4ryF for ; Mon, 26 Jul 2021 18:07:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8A3E41BC05 for ; Mon, 26 Jul 2021 18:07:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 16QI7tCP080884 for ; Mon, 26 Jul 2021 18:07:55 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 16QI7tM1080883 for bugs@FreeBSD.org; Mon, 26 Jul 2021 18:07:55 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 255745] resume on T490 Thinkpad often broken after upgrade 12 -> 13 Date: Mon, 26 Jul 2021 18:07:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: john.grafton@runbox.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255745 --- Comment #19 from John Grafton --- After more testing, I was able to get 6abe97c0140d54d3520c30517b2bdebc3de92= a62 to fail (making my previous comment incorrect). Thus I went back to the beginning of 13-CURRENT to find the where the issue made its way into the c= ode base. Instead of November 2020, it appears to have been added in July 2020. I've spent the past week `git bisecting` my way through CURRENT looking for= the beginning of the suspend/resume issue. Here's a brief description of my testing methodology: 1) Build world / kernel on 12 core system in a 12.2 jail (takes ~ 1/2 hour) 2) Install world / kernel on laptop from NFS to new boot environment on lap= top 3) Boot laptop into new boot environment 4) Compile DRM driver for current kernel 5) kldload i915kms driver 6) Close lid and leave closed for 5 seconds 7) Open lid and wait to see if the system fails to resume 8) Repeat lid close and open in console 15 times and in X 5 times 9) If resume fails, mark bisect fail, if all resumes succeed, mark bisect g= ood Usually, resumes would fail after 5 or so tries. I never had a resume fail= in X that didn't first fail in the console. It did not seem to make a differe= nce if I was on the console or in X.org. I found that before 12b2f3daaa597f346a4b0065bf7f75378524ef88 the X1 Carbon = Gen 6 resumes all 20 times without issue. The main flaw in my methodology is assuming 20 suspend and resumes are enough to accurately test for the issue= .=20=20 I'm currently using src commit e7677232d6eed5f5cae80c1d5968eea5b9266b59 with graphics/drm-current-kmod from ports commit d9b8d3b2b3b5ffcf4b83572098d64803fe237b90 as my daily laptop to test the assumption that 20 suspend and resumes are enough to make a generalization about whether my tests were valid. Oddly, commit 12b2f3daaa597f346a4b0065bf7f75378524ef88 being flagged as the issue is very strange to me because that commit appears to be essentially a NOOP as it's just cleaning up #ifdef statements for older systems. 12.2 wh= ich does not fail at all seems to have similar patches in place. My next steps are to continue testing this older commit as my daily laptop = and see if I can get it to fail. Then attempt to build a version of 13-RELEASE with what appears to be the offending patch removed and see if it fails. --=20 You are receiving this mail because: You are the assignee for the bug.=