Date: Wed, 31 Mar 1999 13:36:44 +0100 From: Tom Hukins <tom@eborcom.com> To: Satoshi - the Wraith - Asami <asami@FreeBSD.ORG> Cc: freebsd-ports@FreeBSD.ORG Subject: Re: Problems with p5-* ports Message-ID: <19990331133644.A12048@eborcom.com> In-Reply-To: <199903302330.PAA45505@silvia.hip.berkeley.edu>; from Satoshi - the Wraith - Asami on Tue, Mar 30, 1999 at 03:30:42PM -0800 References: <19990322162220.A6658@eborcom.com> <Pine.HPP.3.96.990322152834.10524C-100000@hp9000.chc-chimes.com> <19990330172006.A18680@eborcom.com> <199903302330.PAA45505@silvia.hip.berkeley.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 30, 1999 at 03:30:42PM -0800, Satoshi - the Wraith - Asami wrote:
>
> * +.if defined(PERL5_MODULE)
> * + @(cd ${WRKSRC} && \
> * + ${SETENV} ${MAKE_ENV} ${PERL} Makefile.PL PREFIX=${PREFIX} \
> * + INSTALLMAN1DIR=${PREFIX}/man/man1 \
> * + INSTALLSCRIPT=${PREFIX}/bin)
> * +.endif
>
> I'm not sure if this is good. I've seen many different combinations
> of settings, and some USE_PERL5 ports don't even have this line.
I think I haven't explained my thoughts very clearly. PERL5_MODULE
is only defined if the port is a typical CPAN module collection
which configures with Makefile.PL. There are many USE_PERL5 ports
which are not CPAN modules. Such ports should not define
PERL5_MODULE, but they should use PERL5_DEPENDS to specify which
PERL5_MODULE ports they depend on, if any.
Does this sound reasonable?
> * +perl5-depends:
> * +.if defined(PERL5_DEPENDS)
> * +.if !defined(NO_DEPENDS)
> * + @for i in ${PERL5_DEPENDS}; do \
> * + lib=`${ECHO} $$i | ${SED} -e 's/\..*//' | ${SED} -e 's!/!::!g'`; \
> * + version=`${ECHO} $$i | ${SED} -e 's/[^\.]*\.//' | ${SED} -e 's/:.*//'`; \
> * + dir=`${ECHO} $$i | ${SED} -e 's/[^:]*://'`; \
>
> Where's "target" defined? (Did you test this patch?)
I did test the patch, but this error slipped through. You can't "use
strict" on Makefiles. :(
If you add:
target=${DEPENDS_TARGET}; \
after the "dir=" line, everything works properly.
> I don't know perl jargon but the rest looks ok.
Great! I'm fairly certain the Perl jargon is correct - I'm much more
comfortable with Perl than Makefiles.
Tom
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990331133644.A12048>