From owner-cvs-all  Mon Nov 25 23: 8:14 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id AD1D637B401; Mon, 25 Nov 2002 23:08:12 -0800 (PST)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EC0CE43E4A; Mon, 25 Nov 2002 23:08:11 -0800 (PST)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.3/8.12.3) with ESMTP id gAQ785pk046533;
	Tue, 26 Nov 2002 00:08:06 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Tue, 26 Nov 2002 00:05:29 -0700 (MST)
Message-Id: <20021126.000529.95577539.imp@bsdimp.com>
To: julian@elischer.org
Cc: grog@FreeBSD.org, bde@zeta.org.au, julian@FreeBSD.org,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/fsck_ffs pass5.c
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <Pine.BSF.4.21.0211252225370.46897-100000@InterJet.elischer.org>
References: <20021125.231623.131888344.imp@bsdimp.com>
	<Pine.BSF.4.21.0211252225370.46897-100000@InterJet.elischer.org>
X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message: <Pine.BSF.4.21.0211252225370.46897-100000@InterJet.elischer.org>
            Julian Elischer <julian@elischer.org> writes:
: All 3 had the parens. I think it makes it more readable. And you don't.

And neither does the rest of the file:

		if (fs->fs_maxcontig < 2 && fs->fs_contigsumsize > 0) {
			} else if (fs->fs_contigsumsize < fs->fs_maxcontig &&
				   fs->fs_contigsumsize < FS_MAXCONTIG) {
		if (cursnapshot == 0 &&
		    memcmp(&newcg->cg_cs, cs, sizeof *cs) != 0 &&
		    dofix(&idesc[0], "FREE BLK COUNT(S) WRONG IN SUPERBLK")) {
		if (cursnapshot == 0 &&
		    memcmp(newcg, cg, basesize) != 0 &&
		    dofix(&idesc[2], "SUMMARY INFORMATION BAD")) {
			memmove(cg, newcg, (size_t)basesize);
		if (bkgrdflag != 0 || usedsoftdep || debug) {
		if (cursnapshot == 0 &&
		    memcmp(cg_inosused(newcg), cg_inosused(cg), mapsize) != 0 &&
		    dofix(&idesc[1], "BLK(S) MISSING IN BIT MAPS")) {
	if (cursnapshot == 0 &&
	    memcmp(&cstotal, &fs->fs_cstotal, sizeof cstotal) != 0
	    && dofix(&idesc[0], "SUMMARY BLK COUNT(S) WRONG IN SUPERBLK")) {

Every single other use in the file doesn't use parens.  The closest
one is one case where they are really needed:
			if ((j & l) == (k & l))

So I plan on making it consistant when the freeze lifts.

What's so hard about following the existing style?  This is why the
rule was originally there.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message