From owner-svn-src-head@freebsd.org  Tue Aug  2 14:17:39 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C5ABBAC3A2;
 Tue,  2 Aug 2016 14:17:39 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 121C5137A;
 Tue,  2 Aug 2016 14:17:39 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 114DA1FFF; Tue,  2 Aug 2016 14:17:39 +0000 (UTC)
Date: Tue, 2 Aug 2016 14:17:39 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Pedro F. Giffuni" <pfg@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org, Mikhail Teterin <mi@FreeBSD.org>
Subject: Re: svn commit: r303047 - head/usr.bin/sed
Message-ID: <20160802141738.GA84154@FreeBSD.org>
References: <201607192256.u6JMuewv007503@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201607192256.u6JMuewv007503@repo.freebsd.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Aug 2016 14:17:39 -0000

On Tue, Jul 19, 2016 at 10:56:40PM +0000, Pedro F. Giffuni wrote:
> New Revision: 303047
> URL: https://svnweb.freebsd.org/changeset/base/303047
> 
> Log:
>   sed(1):	Assorted cleanups and simplifications.
>   
>   Const-ify several variables, make it build cleanly with WARNS level 5.
>   
>   Submitted by:	mi
>   PR:		195929
>   MFC after:	1 month

Hi Pedro,

This change causes `games/openttd' to fail now, because the generated
`$wrkdir/openttd-1.6.1/objs/release/Makefile' file is broken (SRCS var
is set to bogus value, search for ^SRCS).  Reverting usr.bin/sed back
to r303046 fixes it.

The latest revision (with ngie@'s fix) exhibits the same problem.

Now the port uses somewhat obscure build system, but the sed(1) magic
happens inside generate_foo() functions using SRC_REPLACE variable set
in make_sed() inside `config.lib' file; these functions are called by
the configure script.

Would you or Mikhail mind taking a look?  Thanks,

./danfe